Bug 426199 - frameworks-kglobalaccel build requires X11 on Linux
Summary: frameworks-kglobalaccel build requires X11 on Linux
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kglobalaccel
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.73.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-05 04:28 UTC by Leonard Lausen
Modified: 2022-05-11 19:30 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kglobalaccel/-/commit/7d6ef389defbcf8fc25762ce772315221a721790
Version Fixed In: 5.94
Sentry Crash Report:

Attachments
patch (657 bytes, patch)
2020-09-05 04:28 UTC, Leonard Lausen 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Leonard Lausen 2020-09-05 04:28:20 UTC 
Created attachment 131426 [details]
patch

kglobalaccel supports building without X11 only on MacOS.

OBSERVED RESULT
Building kglobalaccel for Wayland requires building with X11 too.

EXPECTED RESULT
kglobalaccel can be built without X11 support on Linux.

Attached is a simple patch to add an USE_X11 option to the CmakeLists.txt. There might be a more idiomatic way with ECM, but this sufficed to try build kglobalaccel without X11.
Comment 1 Christoph Feck 2020-09-28 09:47:45 UTC 
Please submit patches via our Gitlab instance. For more information, please read https://community.kde.org/Get_Involved/development#Submit_a_Merge_Request