Bug 426196 - Dolphin can incorrectly move files/folders while holding down the Control key
Summary: Dolphin can incorrectly move files/folders while holding down the Control key
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 20.08.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-05 03:22 UTC by umbreon
Modified: 2020-09-05 20:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 20.08.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description umbreon 2020-09-05 03:22:56 UTC
Dolphin can incorrectly move files/folders while holding down the Control key

STEPS TO REPRODUCE
1. mkdir -p ~/test/test2
2. touch ~/test/test2/file.txt
3. Open ~/test/test2/ in Dolphin
4. Open ~/test/ in a new Dolphin window (using another window is important; the issue seems to not occur if using tabs within the same Dolphin window)
5. WITHOUT holding down the Control key and WITHOUT releasing the left mouse button, drag ~/test/test2/file.txt to ~/test
6. After the mouse is finished moving, hold down the Control key WITHOUT moving the mouse any further, and then release the left mouse button

OBSERVED RESULT
After releasing the left mouse button, file.txt is moved from ~/test/test2 into ~/test rather than being copied.

EXPECTED RESULT
After releasing the left mouse button, file.txt should be copied from ~/test/test2 into ~/test.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2

ADDITIONAL INFORMATION
I noticed that if I use a single Dolphin window (with ~/test/test2 and ~/test as separate tabs) to perform the file copy operation, the issue seems to not occur.

Issue does not occur when running Kubuntu 20.04.1 LTS from a live image. (Dolphin version 19.12.3)
Issue occurs when running neon-user-20200827-0945.iso from a live image. (Dolphin version 20.08.0)
Issue occurs when running neon-testing-20200901-1829.iso from a live image. (Dolphin version 20.08.0)
Issue occurs when running neon-unstable-20200830-0330.iso from a live image. (Dolphin version 20.11.70)
Issue still occurs after installing KDE neon Unstable Edition and updating all packages. (Dolphin version 20.11.70)

The system I first encountered this issue on is running Manjaro, but this does not seem to be a Manjaro-specific issue.
Comment 1 umbreon 2020-09-05 06:12:20 UTC
I did some experimenting and it seems that this issue was introduced in Dolphin version 20.07.80.
Everything works as expected if I use version 20.04.3.

It seems like the issue is caused by the change here: https://phabricator.kde.org/D28370
If I undo that change and recompile Dolphin, files are copied as expected.
Comment 2 Elvis Angelaccio 2020-09-05 20:54:37 UTC
Git commit aee26d29f188427186b6aaba1c54a205c17b3dc6 by Elvis Angelaccio.
Committed on 05/09/2020 at 20:51.
Pushed by elvisangelaccio into branch 'release/20.08'.

Revert "Set a better defaultDropAction for dragging"

This reverts commit 4440e961a07aaee5b5da7c8967ff05de14808ad4.
Related: bug 425757
FIXED-IN: 20.08.2

M  +1    -1    src/kitemviews/kitemlistcontroller.cpp

https://invent.kde.org/system/dolphin/commit/aee26d29f188427186b6aaba1c54a205c17b3dc6