Bug 426100 - Unnecessary inline message after the password dialog to add username to sambashare group is canceled without providing the password
Summary: Unnecessary inline message after the password dialog to add username to samba...
Status: RESOLVED FIXED
Alias: None
Product: kdenetwork-filesharing
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: Harald Sitter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-02 14:45 UTC by Patrick Silva
Modified: 2025-07-16 23:07 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screenshot (41.97 KB, image/png)
2020-09-02 14:45 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-09-02 14:45:39 UTC
Created attachment 131360 [details]
screenshot

SUMMARY
As we can see in the attached screenshot, "Share" tab shows "Group changes failed." inline message after the password dialog to add username to "sambashare" group to be canceled. In fact group changes did not failed in this case, they just were intentionally canceled.

STEPS TO REPRODUCE
1. start Plasma with a user account not present in "sambashare" group
2. open Dolphin
3. open properties window of a folder and click on "Share" tab
4. click on "Make me a group member" button
5. cancel the password dialog

EXPECTED RESULT
no inline message

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Comment 1 Harald Sitter 2020-09-02 15:23:57 UTC
That's a code shortcut by design. The exact reason for why the transaction wasn't carried out isn't being taken into account as there's a mountain of reasons and mapping them all to unique strings is a waste of time for a dialog people only ever sees once per installation. And at the same time there ought to be some feedback even when the user cancels because the cancelling can happen in all sorts of unobvious ways such as hitting esc randomly.
Comment 2 Patrick Silva 2025-07-16 23:07:25 UTC
Cannot reproduce.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 6.4.80
KDE Frameworks Version: 6.17.0
Qt Version: 6.9.1
Graphics Platform: Wayland