Bug 426084 - Gtk2 apps like claws-mail don't use the dark breeze theme
Summary: Gtk2 apps like claws-mail don't use the dark breeze theme
Status: RESOLVED DUPLICATE of bug 412331
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.19.5
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-02 02:15 UTC by Jim Jones
Modified: 2020-09-09 18:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Jones 2020-09-02 02:15:48 UTC
SUMMARY
Gtk3 apps don't use the dark breeze theme

STEPS TO REPRODUCE
1. change theme to breeze-dark
2. set theme for gtk3 to breeze (breeze-dark is missing)
3. start claws-mail

OBSERVED RESULT
claws-mail uses the light breeze theme

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.73
Qt Version: 5.15.0

ADDITIONAL INFORMATION
Comment 1 Jim Jones 2020-09-02 02:27:41 UTC
Why was the breeze-dark theme removed for gtk3?

Setting Adwaita-dark as theme gives me a dark theme for claws-mail but it would prefer the breeze-dark theme
Comment 2 Jim Jones 2020-09-02 02:30:30 UTC
btw the dark theme was working for claws-mail before and it seems other gtk3 apps like pavucontrol work and use the breeze-dark theme when i set "Breeze" for gtk3 apps in the settings
Comment 3 Jim Jones 2020-09-03 07:40:53 UTC
it seems claws-mail is a gtk2 app but changing the gtk2 settings doesn't effect the theme, only changing the gtk3 theme effects claws-mail but as explained in a wiered way, while Breeze gives a dark skin for firefox and pavucontrol, claws-mails stays in the light version although changing gtk3 to  Adwaita-dark also shows a dark theme for claws-mail
Comment 4 inasprecali 2020-09-03 15:22:17 UTC
I can confirm this exact same problem in Plasma 5.19.5. GTK 2 applications don't seem to respect themes.

Additional information (copied from settings panel):

Operating System: Gentoo Linux
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0
Kernel Version: 5.8.5-gentoo
OS Type: 64-bit
Processors: 8 × AMD FX(tm)-8350 Eight-Core Processor
Memory: 15.6 GiB of RAM
Graphics Processor: AMD Radeon™ HD8800 Series

I'm willing to provide more specific information if necessary.

(In reply to Jim Jones from comment #1)
> Why was the breeze-dark theme removed for gtk3?

It's superfluous now: the GTK 3 Breeze theme picks colors from the "Colors" system setting. GTK 2 still needs a separate theme, though.
Comment 5 Nate Graham 2020-09-08 16:47:02 UTC
Fixed in Plasma 5.20
Comment 6 Jim Jones 2020-09-08 21:06:30 UTC
can you please tell us which commit fixed the problem?
Comment 7 Nate Graham 2020-09-08 21:11:09 UTC
Actually I was mis-remembering: turns out it's actually not easily possible given GTK2's theming limitations in the face of the way we theme GTK3 apps. Sorry.

GTK2 is an ancient toolkit which has been deprecated for years, and GTK4 is about to be released. Apps should reeeeeeeeeally get to work porting over.

*** This bug has been marked as a duplicate of bug 412331 ***
Comment 8 Jim Jones 2020-09-08 21:16:18 UTC
But it was working before I updated to kde-frameworks-5.73 and kde-plasma-5.19.5
Comment 9 inasprecali 2020-09-09 17:57:50 UTC
(In reply to Jim Jones from comment #8)
> But it was working before I updated to kde-frameworks-5.73 and
> kde-plasma-5.19.5
Same here.

(In reply to Nate Graham from comment #7)
> Actually I was mis-remembering: turns out it's actually not easily possible
> given GTK2's theming limitations in the face of the way we theme GTK3 apps.
> Sorry.
It was possible before this update, though. This is a regression.

> GTK2 is an ancient toolkit which has been deprecated for years, and GTK4 is
> about to be released. Apps should reeeeeeeeeally get to work porting over.
No demands as a user, of course, but if you deem GTK2 to be ancient and deprecated (which I agree with) then you should just stop supporting it. Having an option to apply GTK2 themes which doesn't actually work is a bug, plain and simple.
Comment 10 Nate Graham 2020-09-09 18:13:18 UTC
(In reply to inasprecali from comment #9)
> > GTK2 is an ancient toolkit which has been deprecated for years, and GTK4 is
> > about to be released. Apps should reeeeeeeeeally get to work porting over.
> No demands as a user, of course, but if you deem GTK2 to be ancient and
> deprecated (which I agree with) then you should just stop supporting it.
> Having an option to apply GTK2 themes which doesn't actually work is a bug,
> plain and simple.
I agree, which is why it was removed in Plasma 5.20. :)