Bug 426009 - Annotations are broken after upgrade
Summary: Annotations are broken after upgrade
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.11.0
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-31 02:06 UTC by Rafael Giusti
Modified: 2020-09-06 10:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Giusti 2020-08-31 02:06:59 UTC
After Okular was upgrade to version 1.11.0, my predefined annotations were mixed with the buttons in the annotation toolbar. In my particular case, selecting the "highlighter" button actually enables the "popup note" tool. The "underline" button enables the "inline note" tool. The "squiggle" button enables a red freehand line. The "strike out" button enables a cyan freehand line. These were some of the annotations I had configure in the previous version.


STEPS TO REPRODUCE
1. Install Okular 1.10.3 or 1.10.2
2. Configure some annotations. Make sure to change the order of the annotations, so that some personalized annotations appear before pre-defined ones.
3. Install Okular 1.11.0.

OBSERVED RESULT

1) The buttons in the annotations toolbar will select the wrong functionalities.
2) The user-defined annotations are not properly listed anywhere in the interface (possibly a separate bug?)

EXPECTED RESULT

1) The buttons in the annotations toolbar should work properly; and possibly
2) The buttons in the annotations toolbar should be labeled according user-defined annotations from previous version; or
3) The annotations in the quick menu should reflect the user-defined annotations previously set.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian "testing", KDE 5 (running on Xfce, further information unknown to bug poster)
KDE Plasma Version: Unknown to bug poster
KDE Frameworks Version: Unknown to bug poster
Qt Version: Unknown to bug poster

ADDITIONAL INFORMATION

I am on Xfce and I do not know how to obtain all information required above. I'll be glad to comply if someone with the knowledge could drop a link or a comment
Comment 1 Simone Gaiarin 2020-09-02 08:16:30 UTC
> The buttons in the annotations toolbar will select the wrong functionalities.

This should be fixed in 1.11.1, in the meantime the workaround for 1.10.0 is to rename the key AnnotationTools to QuickAnnotationTools in ~/.config/okularpartrc
Comment 2 Albert Astals Cid 2020-09-06 10:08:25 UTC
Git commit cd96735ae236499e0597317c8967a2a2ac551af1 by Albert Astals Cid, on behalf of Simone Gaiarin.
Committed on 06/09/2020 at 10:08.
Pushed by aacid into branch 'release/20.08'.

Maintain quick annotation shortcut compatibility with Okular < 1.11.0

During the upgrade to Okular 1.11.0 the shortcuts for the quick annotations have been changed from the keys 1, 2, 3,... to Alt + 1, 2, 3,... making some users unhappy.

M  +4    -4    autotests/annotationtoolbartest.cpp
M  +11   -11   ui/annotationactionhandler.cpp

https://invent.kde.org/graphics/okular/commit/cd96735ae236499e0597317c8967a2a2ac551af1