Bug 425939 - master branch fails with error class 'ElisaApplicationPrivate’ has no member named ‘mCollection’
Summary: master branch fails with error class 'ElisaApplicationPrivate’ has no member ...
Status: RESOLVED WORKSFORME
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR crash
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-29 13:35 UTC by Caio Tácito
Modified: 2022-11-11 05:21 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Tácito 2020-08-29 13:35:53 UTC
SUMMARY
Compiling elisa from the master branch fails. All required packages are installed.

STEPS TO REPRODUCE
1. clone from the master branch
2. mkdir build && cd build && cmake ..
3. make

OBSERVED RESULT

/home/caio/elisa/src/elisaapplication.cpp: In member function ‘void ElisaApplication::setupActions(const QString&)’:
/home/caio/elisa/src/elisaapplication.cpp:116:52: warning: unused parameter ‘actionName’ [-Wunused-parameter]
  116 | void ElisaApplication::setupActions(const QString &actionName)
      |                                     ~~~~~~~~~~~~~~~^~~~~~~~~~
/home/caio/elisa/src/elisaapplication.cpp: In member function ‘virtual bool ElisaApplication::eventFilter(QObject*, QEvent*)’:
/home/caio/elisa/src/elisaapplication.cpp:494:31: error: ‘class ElisaApplicationPrivate’ has no member named ‘mCollection’
  494 |     auto playPauseAction = d->mCollection.action(tr("Play-Pause"));
      |                               ^~~~~~~~~~~
make[2]: *** [src/CMakeFiles/elisaLib.dir/build.make:219: src/CMakeFiles/elisaLib.dir/elisaapplication.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:325: src/CMakeFiles/elisaLib.dir/all] Error 2


EXPECTED RESULT
Compilation to finish

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Kubuntu 20.04
(available in About System)
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.74.0
Qt Version: 5.12.8

ADDITIONAL INFORMATION
Comment 1 Matthieu Gallien 2020-08-29 14:05:58 UTC
Thanks for your report.

Please can you check if KXmlGui has been detected when executing CMake ?

It looks like we have an optional dependency on KXmlGui and that without it compilation is failing.
Comment 2 Caio Tácito 2020-08-29 14:23:38 UTC
Thanks for replying. I'm assuming KXmlGui is the same thing as KF5XmlGui, I'm sorry if I misunderstood. libkf5xmlgui-dev and libkf5xmlgui5 are both installed, however, apt installed version 5.68.0, while CMake is asking for a version greater than 5.70.0. apt update reports that all packages are up-to-date. It seems that everything related to kf5 on my system is on version 5.68.0, so trying to compile KXmlGui from source results in CMake returning a lot of version errors. How can I update the necessary packages for the version elisa is looking for?
Comment 3 Christoph Feck 2020-08-29 14:28:58 UTC
Please ask in a forum of your distribution if there are (third-party) repositories or PPAs with newer versions.
Generally, if you compile KDE software from master branches, you also need recent frameworks and Qt. I suggest to compile from a branch that matches the version your distribution ships to avoid dependency issues.
Comment 4 Matthieu Gallien 2020-08-29 16:52:37 UTC
Thanks for the information.

Elisa is failing to build without KF5 XmlGui framework. I will see what I can do (either make it mandatory or fix the build issue).
Comment 5 Justin Zobel 2022-10-12 03:50:06 UTC
Thank you for reporting this crash in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the crash with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Comment 6 Bug Janitor Service 2022-10-27 05:04:56 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Bug Janitor Service 2022-11-11 05:21:33 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!