Bug 425928 - Breeze icon for keepassxc not being applied
Summary: Breeze icon for keepassxc not being applied
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-29 02:26 UTC by Podagric
Modified: 2020-09-21 04:39 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.74


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Podagric 2020-08-29 02:26:46 UTC
SUMMARY

since version 2.6 of keepassxc, the breeze icon for this program is not being displayed. instead, the own icon is being used.

With this new version, keepassxc has had a lot of visual changes, including for the systray icon. Maybe the file has changed its name? well I don't know much about it :/

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0
Kernel Version: 5.8.4-arch1-1
OS Type: 64-bit
Comment 1 Nate Graham 2020-08-29 02:49:55 UTC
Quite likely that it changed its name. If you can find out what the new name is that it's looking for, we can make a compatibility symlink. Can you send me the output of `find /usr/share/icons/hicolor/ | grep -i keepas` on your system?
Comment 2 Podagric 2020-08-29 02:53:29 UTC
/usr/share/icons/hicolor/256x256/apps/keepassxc.png
/usr/share/icons/hicolor/scalable/apps/keepassxc.svg
/usr/share/icons/hicolor/scalable/apps/keepassxc-monochrome-light-locked.svg
/usr/share/icons/hicolor/scalable/apps/keepassxc-locked.svg
/usr/share/icons/hicolor/scalable/apps/keepassxc-monochrome-light.svg
/usr/share/icons/hicolor/scalable/apps/keepassxc-monochrome-dark.svg
/usr/share/icons/hicolor/scalable/apps/keepassxc-unlocked.svg
/usr/share/icons/hicolor/scalable/apps/keepassxc-monochrome-dark-locked.svg
/usr/share/icons/hicolor/scalable/mimetypes/application-x-keepassxc.svg
Comment 3 Podagric 2020-08-29 02:56:50 UTC
I think the bug will only occur when the breeze-dark theme is activated, correct? since they changed the name only the monochrome icon files
Comment 4 Nate Graham 2020-08-29 02:58:16 UTC
Thanks. Fixing momentarily.
Comment 5 Nate Graham 2020-08-29 03:01:09 UTC
Git commit e0be13070bc751feb223020153ea92838ce93df2 by Nate Graham.
Committed on 29/08/2020 at 03:00.
Pushed by ngraham into branch 'master'.

Add another alias for keepass icon

They keep changing the icon name, so we need to add another alias (this
time it's `keepassxc`)
FIXED-IN: 5.74

A  +30   -0    icons-dark/apps/48/keepassxc.svg
A  +30   -0    icons/apps/48/keepassxc.svg

https://invent.kde.org/frameworks/breeze-icons/commit/e0be13070bc751feb223020153ea92838ce93df2
Comment 6 Podagric 2020-08-29 03:16:06 UTC
the change you made solved a possible other bug because of the file name change, but I didn't mean this hehe.

the problem was related to the systray icon. the one in /usr/share/icons/breeze-dark/status/22/.
I created a symlink and solved the problem
ln -s keepassxc-unlocked.svg keepassxc-monochrome-light.svg
ln -s keepassxc-locked.svg keepassxc-monochrome-light-locked.svg
Comment 7 Nate Graham 2020-08-29 03:16:55 UTC
whoops, let me get those too
Comment 8 Nate Graham 2020-08-29 03:20:38 UTC
Git commit 717157acf3bfdf608d28b341a753c3b5104501dd by Nate Graham.
Committed on 29/08/2020 at 03:20.
Pushed by ngraham into branch 'master'.

Add more symlinks for new keepassxc system tray icon names

A  +1    -0    icons-dark/status/22/keepassxc-monochrome-dark-locked.svg
A  +1    -0    icons-dark/status/22/keepassxc-monochrome-dark.svg
A  +1    -0    icons/status/22/keepassxc-monochrome-light-locked.svg
A  +1    -0    icons/status/22/keepassxc-monochrome-light.svg

https://invent.kde.org/frameworks/breeze-icons/commit/717157acf3bfdf608d28b341a753c3b5104501dd
Comment 9 Marma 2020-09-18 11:12:35 UTC
I'm sorry, but commit e0be13070bc751feb223020153ea92838ce93df2 is WRONG.

This is about KeePassXC, and NOT KeePass.

The old green leaf-like icon has nothing to do with KeePassXC.

Please revert commit e0be13070bc751feb223020153ea92838ce93df2.

The latest commit 717157acf3bfdf608d28b341a753c3b5104501dd is correct.

Thanks in advance.
Comment 10 Nate Graham 2020-09-18 19:51:28 UTC
So wait, keepass and keepassxc are different apps with different icons?
Comment 11 Marma 2020-09-18 22:13:28 UTC
First of all, sorry for the tone of my previous comment.

KeePass is a Windows-only application, while KeePassXC is a standalone community fork with Linux support and with different branding. But now, that I'm thinking more about it...

I can only guess that years ago, the fork used "keepass" icon name, and that's why the Breeze icon theme contains an icon called "keepass". Otherwise, it doesn't make sense to me, because KeePass is a Windows-only application, so why even bother creating a custom icon for it?

But I've been using KeePassXC for years with the default Breeze icon theme, and I've never seen the custom green leaf-like icon provided by the Breeze icon theme. So it must have been a long time since that icon isn't used?

As for the tray icon, its style resembles the original icon, and it's just  adapted to the Breeze's tray icon guidelines. In version 2.6.0 KeePassXC's developers introduced their own, official monochrome icon variants. However, I find them to be too fat in comparison to other system tray icons, and I think that the custom icon provided by the Breeze icon theme fits better. In my opinion, the latest commit that overrides the official monochrome icons is correct. So, thank you for doing that.

As for the application icon, the green leaf-like icon doesn't resemble the original icon. But if that custom icon has been actually designed for KeePassXC (but got lost due to some upstream changes), then it can make a come-back, I guess? Personally I'm used to the official KeePassXC icon, but I wouldn't mind that change. The question is, whether upstream does not mind about overriding their official icon, given it's quite different and can cause some confusion. I'm not in a position to decide about such things.
Comment 12 Nate Graham 2020-09-21 03:38:00 UTC
So right now we have two icons:
- The old-style leaf-ish icon which is used for "keepass" "keepassx" "keepass2" and "keepassx2"
- The new-style key-ish icon which is used for "keepassxc"

On first glance this looks sane and correct to me, but I'm not a user of any of these apps and am not super familiar with the requirements. Noah, I know you use one of these, so could you shed some light on the situation? Thanks!
Comment 13 Noah Davis 2020-09-21 04:23:43 UTC
The issue is already fixed in commit 44a95a9cc821e5ee39310063b8062cf5f7daefdd, so nothing needs to be done
Comment 14 Nate Graham 2020-09-21 04:39:18 UTC
OK cool, thanks so much!