Bug 425834 - Now playing tab needs padding
Summary: Now playing tab needs padding
Status: VERIFIED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 20.08.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-26 13:34 UTC by ratijas
Modified: 2020-08-27 05:44 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 20.12.0


Attachments
Screenshot shows the "Now Playing" tab (405.26 KB, image/png)
2020-08-26 13:34 UTC, ratijas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ratijas 2020-08-26 13:34:09 UTC
Created attachment 131200 [details]
Screenshot shows the "Now Playing" tab

SUMMARY

Lyrics text area in the "Now playing" tab is not padded, which makes lines sometimes stick to the edges

STEPS TO REPRODUCE
1. Play track with lyrics.
2. Switch to the "Now Playing" tab.
3. Resize the window, so that longest lyrics line fits exactly into text area without wrapping.

OBSERVED RESULT

Text visually sticks to the edges.

EXPECTED RESULT

Some 8pt or 16pt padding would be nice.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Not relevant
(available in About System)
KDE Plasma Version: Not relevant
KDE Frameworks Version: Not relevant
Qt Version: 5.15.0-4

ADDITIONAL INFORMATION

Check out screenshot
Comment 1 Nate Graham 2020-08-26 18:06:40 UTC
Git commit ff598313e5d030dc512c544bdc690a1009f7ec9a by Nate Graham.
Committed on 26/08/2020 at 18:05.
Pushed by ngraham into branch 'master'.

Add appropriate side margins for content in Now Playing view
FIXED-IN: 20.12.0

M  +81   -66   src/qml/ContextView.qml

https://invent.kde.org/multimedia/elisa/commit/ff598313e5d030dc512c544bdc690a1009f7ec9a
Comment 2 ratijas 2020-08-27 05:44:19 UTC
Yes! Now the look & feel are waaay smoother than before. Thanks!