Bug 425827 - Bottom of "Addons" popup is behind Plasma panel
Summary: Bottom of "Addons" popup is behind Plasma panel
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-26 11:17 UTC by Patrick Silva
Modified: 2020-08-31 19:56 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.20
Sentry Crash Report:


Attachments
screen recording (1.14 MB, video/webm)
2020-08-26 11:17 UTC, Patrick Silva
Details
popup is cut off on top after the first opening (1.39 MB, video/webm)
2020-08-31 18:09 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-08-26 11:17:52 UTC
Created attachment 131195 [details]
screen recording

SUMMARY
Watch the attached screen recording please.

EXPECTED RESULT
"Addons" popup should be entirely visible

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.74.0
Qt Version: 5.14.2
Comment 1 Nate Graham 2020-08-26 17:49:11 UTC
It's not below the plasma panel, it's just cut off at the bottom of the window. Will fix.
Comment 2 Bug Janitor Service 2020-08-26 19:37:45 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/27
Comment 3 Nate Graham 2020-08-27 14:15:04 UTC
Git commit 4087d2b4ee5cec5b7f45de3126960014df840c2f by Nate Graham.
Committed on 27/08/2020 at 14:14.
Pushed by ngraham into branch 'master'.

Improve and modernize UI of Addons sheet

Various improvements:
- Put the bottom buttons in a footer so they can't scroll out of view
- Rename "Discard" button to "Reset" since "Discard" implies closing the
  sheet
- Move Apply and Reset buttons over to the right side, as is typical
- Disable rather than hide the Apply and Reset buttons
- Remove the icons since they add no information and were all the same
- Make subtext less opaque rather than italic, as is our style (we can't
  simply port to `Kirigami.BasicListItem` yet because it can't support
  showing a checkbox to the left of the icon)
FIXED-IN: 5.20

M  +24   -33   discover/qml/AddonsView.qml

https://invent.kde.org/plasma/discover/commit/4087d2b4ee5cec5b7f45de3126960014df840c2f
Comment 4 Patrick Silva 2020-08-31 18:09:53 UTC
Created attachment 131323 [details]
popup is cut off on top after the first opening

Now, as we can see in this new screen recording, the popup is cut off on top after the first opening.
Comment 5 Nate Graham 2020-08-31 19:56:52 UTC
That's strange. Works fine for me. If it doesn't go away, it's most like a Kirigami OverlaySheet bug.