Bug 425718 - Hide button of annotation toolbar may move to second row as a single item
Summary: Hide button of annotation toolbar may move to second row as a single item
Status: RESOLVED INTENTIONAL
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.11.0
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-23 16:51 UTC by postix
Modified: 2020-08-23 18:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot (53.65 KB, image/png)
2020-08-23 16:51 UTC, postix
Details
Screenshot: Mockup (59.79 KB, image/png)
2020-08-23 16:53 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-08-23 16:51:48 UTC
Created attachment 131129 [details]
Screenshot

The hide button would perfectly fit, but instead the ">" is shown for the the second row of toolbar buttons, though only for the hide button.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.0

ADDITIONAL INFORMATION
Scaling: 2.0
Comment 1 postix 2020-08-23 16:53:34 UTC
Created attachment 131130 [details]
Screenshot: Mockup

There's actually space.
Comment 2 Laura David Hurka 2020-08-23 18:06:52 UTC
> There's actually space.
Yes.

> The hide button would perfectly fit
No, not perfectly.

For a smart user it looks obvious that there is enough space for the red circle. But this button is a tool button with a square icon, and thus has the same size as the “Keep Active” button next to it.a

You can see in your screenshot that “Keep Active” is square, but the button with the arrow is not square, and so fits there. This is probably because the arrow is not an icon, but a “GUI primitive”, which happens to be narrower in Breeze widget style.

Probably one of these: https://doc.qt.io/qt-5/qstyle.html#PrimitiveElement-enum

Closing as INTENTIONAL, because the size hint concept of the Qt layouting system is designed too simple to communicate “I can fit there if you allow me to put less padding arround the icon than the specified minimum in the Breeze widget style”; and Okular just uses this system.

If this is an issue, you could try e. g. Fusion widget style, that uses less padding.
Comment 3 postix 2020-08-23 18:09:30 UTC
Thank you for the explanation!