Bug 425675 - Buttons in toolbar exceed toolbar with Material or Universal style
Summary: Buttons in toolbar exceed toolbar with Material or Universal style
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-22 13:22 UTC by Nicolas Fella
Modified: 2020-09-03 10:24 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (5.44 KB, image/png)
2020-08-22 13:22 UTC, Nicolas Fella
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Fella 2020-08-22 13:22:55 UTC
Created attachment 131096 [details]
Screenshot

With Material or Universal QQC2 style the Toolbuttons have an implicit size larger than the page's toolbar. This results in the buttons exceeding the toolbar.

It boils down to 1) the ActionToolbar in the globaltoolbarui not having an explicit size and 2) the ActionToolbar not propagating that explicit size to its delegated.

It seems to look properly with qqc2-desktop-style and Plasma by pure chance
Comment 1 Arjen Hiemstra 2020-09-03 10:24:58 UTC
Git commit e95f9ecf930ec252023ff7d90fa4f276717a5503 by Arjen Hiemstra.
Committed on 03/09/2020 at 10:24.
Pushed by ahiemstra into branch 'master'.

Add a property to ToolBarLayout to control how to deal with item height

By default, items will now be constrained by the toolbar height, with
smaller items centered. A property is exposed however that allows
controlling the behaviour, setting it either to always match the toolbar
height or to never affect item height.

M  +7    -0    src/controls/ActionToolBar.qml
M  +28   -1    src/toolbarlayout.cpp
M  +26   -0    src/toolbarlayout.h
M  +6    -0    src/toolbarlayoutdelegate.cpp
M  +1    -0    src/toolbarlayoutdelegate.h

https://invent.kde.org/frameworks/kirigami/commit/e95f9ecf930ec252023ff7d90fa4f276717a5503