Bug 425659 - [Request] More sliders/UX improvements to the Filter interface
Summary: [Request] More sliders/UX improvements to the Filter interface
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: 4.3.0
Platform: Other All
: NOR wishlist
Target Milestone: ---
Assignee: Sachin Jindal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-21 23:59 UTC by tomtomtomreportingin
Modified: 2021-01-20 06:57 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tomtomtomreportingin 2020-08-21 23:59:50 UTC
SUMMARY
It's a bit jarring to the user's experience to set up a filter layer for Random Noise and realize they'd have to hold on to the tiny arrow buttons or reach across the keyboard to type in a value they would like, especially when other filters (like HSL Adjustment and Gaussian Blur) and other parts of the interface (like Size/Flow/Opacity on the toolbar) don't act like this.

I will note the following filters (separated by their categories) that could use more sliders instead of pure text boxes:

Index Colors
Oil Paint
Pixelize
Posterize
Raindrops

Blur (this one also lacks a dial for configuring the angle)
Lens Blur (also lacks a dial)
Motion Blur (this one DOES have a dial though)

Gaussian High Pass

Emboss with Variable Depth

Gaussian Noise Reducer
Unsharp Mask
Wavelet Noise Reducer

Phong Bumpmap's Light Sources tab (has a dial for Azimuth but not one for Inclination)
Round Corners
Small Tiles

Random Noise
Random Pick
Wave

I would hope these would not be too troublesome to implement. Perhaps there could be an argument for sliders taking too much space in the UI, but most of these filters have a lot of empty space. If one were to configure them using the smaller window of Layer Properties, Gaussian Blur for example seems to have handled a smaller slider well enough.

I guess there's also an argument for slightly breaking existing workflows. For example, you can currently double left-click the Random Noise textboxes to type in your preferred value, but if it had a slider like Gaussian Blur, you'd have to right-click to manually type in your preferred value. However, I don't think this would be an issue at all if it used a Slider + Textbox combo like HSV Adjustment.
Comment 1 Tiar 2020-08-22 18:10:39 UTC
Yes, it seems useful and looks like an easy job for a beginner.

Note: the sliders need to have the same range as the numeric boxes have right now.
Comment 2 Sachin Jindal 2020-12-04 16:37:23 UTC
I would like to work on this.
Comment 3 Halla Rempt 2020-12-07 10:03:39 UTC
Please go ahead: there is already a KisSliderSpinbox class that can be used as a drop-in replacement.
Comment 4 Sachin Jindal 2021-01-20 06:57:22 UTC
This Bug/Request is resolved in this MR https://invent.kde.org/graphics/krita/-/merge_requests/652