Bug 425621 - Remove big "Enable Bluetooth" button
Summary: Remove big "Enable Bluetooth" button
Status: RESOLVED INTENTIONAL
Alias: None
Product: Bluedevil
Classification: Plasma
Component: system tray (show other bugs)
Version: 5.19.4
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-21 00:32 UTC by Maksym Hazevych
Modified: 2020-08-21 16:24 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Comprasion between applets (133.55 KB, image/png)
2020-08-21 00:32 UTC, Maksym Hazevych
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maksym Hazevych 2020-08-21 00:32:28 UTC
Created attachment 131060 [details]
Comprasion between applets

SUMMARY
I propose to remove big centered "Enable Bluetooth" button (under "Bluetooth is disabled" text), because it duplicates checkbox in header and for consistency with Networks applet (where there is no similar button).

STEPS TO REPRODUCE
1. Open Bluetooth applet
2. Disable Bluetooth, if not disabled

OBSERVED RESULT
"Enable Bluetooth" button right under "Bluetooth is disabled" text. 

EXPECTED RESULT
No "Enable Bluetooth" button right under "Bluetooth is disabled" text. 

ADDITIONAL INFORMATION
Should be done only after #422696 being fixed - https://bugs.kde.org/show_bug.cgi?id=422696
Comment 1 Maksym Hazevych 2020-08-21 00:37:43 UTC
ADDITION:

Also, "Bluetooth is Disabled" should be changed to "Bluetooth is deactivated" (similar to Networks applet), too. Current text may lead into idea that Bluetooth is broken.

(don`t want to create additional bug report for this small thing)
Comment 2 Nicolas Fella 2020-08-21 12:52:01 UTC
I don't see a reason to remove the button. It gives a clear, prominent and actionalbe way to go forward. If anything I'd add a similar button to the network applet
Comment 3 Nate Graham 2020-08-21 12:53:30 UTC
I agree. We should move towards this for the networks applet, not remove it here. It's slightly redundant, but I think it's good to make it totally obvious what to do.
Comment 4 Nate Graham 2020-08-21 15:41:38 UTC
I've submitted MRs to change the terminology as you suggest though. I think that's a good idea:

https://invent.kde.org/plasma/bluedevil/-/merge_requests/7
https://invent.kde.org/plasma/plasma-nm/-/merge_requests/18
Comment 5 ratijas 2020-08-21 15:56:17 UTC
> I agree. We should move towards this for the networks applet, not remove it here.
> It's slightly redundant, but I think it's good to make it totally obvious what to do.

Nah. Having two completely different types of button 200px away from each other
doing literally the same thing would leave me in frustration questioning 'Oh god,
why? Are they doing something rather unexpected?'

If anything, I'd suggest drawing some nice huge arrow across an empty area,
pointing to the toggle/checkbox. Arrow has to be of a foreground color, of course.
Comment 6 ratijas 2020-08-21 16:04:16 UTC
I mean, I'm not using Bluetooth much on my laptop, so I don't run into this frequently enough to notice. But now I intentionally opened it, and wow... I'm surprised.

Not only it indeed has both the checkbox AND the button, but also checkbox is _DISABLED_ (i.e. grayed out) in its OFF state (i.e. when Bluetooth itself is disabled). And when I enable Bluetooth with the button, checkbox activated, and hovering over it shows 'Enable Bluetooth' tooltip (text already fixed by Nate Graham in the commits above).

So, the checkbox, despite being a toggle, is only good to turn the Bluetooth off. And I think this counter-intuitive UX design is clearly an oversight of VDG, and should be fixed. See my suggestion about an arrow above.
Comment 7 Nate Graham 2020-08-21 16:19:24 UTC
In Plasma 5.20, the whole toolbar disappears when bluetooth is deactivated, so there is only one way to turn it on: the big button.
Comment 8 Nate Graham 2020-08-21 16:20:22 UTC
If we had a real switch control, I would be open to using that, removing the big button, and not hiding the toolbar when disabled. Alas, we do not have this so we're stuck with the current checkbox, which is less than ideal, hence the big button. Let's re-visit once we have a real switch.
Comment 9 ratijas 2020-08-21 16:24:48 UTC
That's... concerning... It shouldn't be a checkbox then anyway. Well, you already got the point.

...

Oh, I know! How moving that checkbox in place of a button, and animating it all the way to the toolbar -- which would at the same time animate down accordingly? Of course nice big text label should still be by its side while deactivated.