Bug 425601 - clicking song title in top bar doesn't work anymore
Summary: clicking song title in top bar doesn't work anymore
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-08-20 16:26 UTC by bayang
Modified: 2020-08-21 18:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 20.12.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description bayang 2020-08-20 16:26:54 UTC
SUMMARY
clicking the title in top bar is broken (while clicking artist or album still works)

STEPS TO REPRODUCE
1. launch Elisa, start to play a song
2. click the song title in top bar

OBSERVED RESULT
Nothing and logs display errors
Errors are : 
qrc:/qml/ContentView.qml:36: TypeError: Property 'closeAllViews' of object ViewManager(0x5571ed7b48b0) is not a function
qrc:/qml/ContentView.qml:36: TypeError: Type error


EXPECTED RESULT
Show now playing view if I recall correctly

From what I can see : 
The code says that clicking the song title calls the function openNowPlaying() which calls viewManager.closeAllViews();

But function closeAllViews has been removed from viewmanager.h in commit https://invent.kde.org/multimedia/elisa/-/commit/79131c04869b2351f7816f0dd7528854694a624d
Comment 1 Nate Graham 2020-08-21 00:11:33 UTC
can reproduce.
Comment 2 Nate Graham 2020-08-21 00:12:17 UTC
I guess it needs to be ported to something else to show the context view.

Wanna take a crack at it? :)
Comment 3 bayang 2020-08-21 06:27:52 UTC
I guess I can have a look :)
Comment 4 Nate Graham 2020-08-21 18:18:08 UTC
For future reference, the commit that fixes the bug needs to use the same email address as the one you're using for your Bugzilla account, or else it doesn't get automatically closed even if you use the BUG: keyword correctly. :)

Manually closing because this is fixed! Woohoo!