Bug 425593 - presentation window resized and moved to top left corner by touch gesture
Summary: presentation window resized and moved to top left corner by touch gesture
Status: REPORTED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.11.0
Platform: Flatpak Linux
: NOR minor
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-20 14:06 UTC by keschurter
Modified: 2020-08-21 00:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screen shot of presentation window in corner of screen (67.48 KB, image/png)
2020-08-20 14:06 UTC, keschurter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description keschurter 2020-08-20 14:06:44 UTC
Created attachment 131040 [details]
screen shot of presentation window in corner of screen

SUMMARY
In presentation mode on a 2-in-1 laptop, a downward stroke on the touchscreen from the top edge of the screen causes the presentation window to be resized and moved to the top left corner of the screen.

STEPS TO REPRODUCE
1. View PDF in presentation mode
2. Using any number of fingers, swipe down from the top edge of the screen

OBSERVED RESULT
  The presentation window is resized and moved to the top left corner of the screen.


EXPECTED RESULT
  Nothing. (Would be nice if this gesture revealed the annotations toolbar, though.)

SOFTWARE/OS VERSIONS
Pop!_OS 20.04
Gnome 3.36


ADDITIONAL INFORMATION
I see the same result when I use a one-, two-, or three-finger touch gesture from the top of the screen. A four-finger downward stroke causes the same change to the presentation window and simultaneously switches the workspace. The workspace switching is the expected behavior in Gnome. The other gestures are not assigned.

I cannot recreate the behavior with a click-and-drag. I thought maybe the touch gesture is grabbing the edge of an invisible title bar that I cannot reach with the touchpad. I see the same result when I turn on/off the "double click window titlebar toggles maximize" setting in Gnome Tweaks.
Comment 1 Laura David Hurka 2020-08-20 19:05:21 UTC
I changed the screen switching code of PresentationWidget to un-fullscreen, move, fullscreen when the screen is changed through the screen selection button. If only un-fullscreen is respected by the window manager, we get the result in your screenshot. The new size is 640×480, which is kind of the standard size of QWidget. But since screen switching is not involved (as I understand you), that is unlikely to be related.

I think someone else did some changes on the top toolbar, to be able to access it on a touchscreen or tablet. I don’t remember when that was.

Do you have the issue only in 1.11, or did you already observe it in 1.10, or maybe even 1.9?

And since you say “presentation window”: Do you set the presentation widget to be windowed (not fullscreen) in your window manager, or is it windowed otherwise? It is intended to be fullscreen, i. e. cover the whole screen with nothing but the page.
Comment 2 keschurter 2020-08-20 20:43:35 UTC
(In reply to David Hurka from comment #1)
> I changed the screen switching code of PresentationWidget to un-fullscreen,
> move, fullscreen when the screen is changed through the screen selection
> button. If only un-fullscreen is respected by the window manager, we get the
> result in your screenshot. The new size is 640×480, which is kind of the
> standard size of QWidget. But since screen switching is not involved (as I
> understand you), that is unlikely to be related.

Correct, I am using the "current screen" option.

> I think someone else did some changes on the top toolbar, to be able to
> access it on a touchscreen or tablet. I don’t remember when that was.
> 
> Do you have the issue only in 1.11, or did you already observe it in 1.10,
> or maybe even 1.9?

I was not using Okular before 1.11. (I was recently looking for a good doc viewer with freehand annotation tools for remote teaching this fall. Found one in Okular. Thanks!)

The same thing happens when I go back to 1.10 and 1.9.2. I tried to bisect the issue, but the flatpak failed to launch for versions <1.9.2.

> And since you say “presentation window”: Do you set the presentation widget
> to be windowed (not fullscreen) in your window manager, or is it windowed
> otherwise? It is intended to be fullscreen, i. e. cover the whole screen
> with nothing but the page.

I did not change anything with X window manager and I am not sure where that configuration option is. Everything looks normal when I first start presentation mode: it covers the whole screen with nothing but the page, no titlebar, etc. But it is always a separate window from the main app window in the sense that using super+` toggles between them. I am not sure if this is what you mean. Please let me know if there is a configuration file you would like to see.

As you say, the presentation widget (window?) appears to forget how large the screen is after I swipe down from the top edge. Hovering over the edges of the widget with the cursor does not show the resizing arrow cursor <->. Using the alt+space shortcut, which brings up the window menu in pop-os, I can resize the shrunken widget. Maximizing it almost restores the presentation to its original state, except that the top bar is still visible.
Comment 3 Laura David Hurka 2020-08-20 21:11:44 UTC
Thanks, that is exactly what I wanted to know!

So I assume that the problem is somewhere in repositionContent() or similar, I would need to look at it again. It needs at least the screen geometry to move the toolbar to its position, I can imagine that Flatpak does not provide it.

As a workaround for you I suggest:
1. (Optional) Set the background color to black
2. View -> View Mode -> Single Page and non-Continuous
3. Hide the sidebar
4. Enable Fullscreen mode (not Presentation mode)
5. Show the Annotation Toolbar with F6
6. Now you can use the “real” annotation tools, but you need more clicks to change the color.

If Fullscreen mode has the same problem, it is probably a Flatpack problem.
Comment 4 Albert Astals Cid 2020-08-20 21:30:15 UTC
(In reply to David Hurka from comment #3)
> If Fullscreen mode has the same problem, it is probably a Flatpack problem.

I very much doubt it is a Flapak problem.
Comment 5 keschurter 2020-08-21 00:10:07 UTC
Full screen mode does have the same problem.