Bug 425327 - No Border warning box still has placeholder string
Summary: No Border warning box still has placeholder string
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (other bugs)
Version First Reported In: 5.19.4
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2020-08-14 00:29 UTC by Chase Jewell
Modified: 2022-07-01 13:41 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chase Jewell 2020-08-14 00:29:01 UTC
SUMMARY


STEPS TO REPRODUCE
1. Click the window menu, which is on the top left of the window decoration by default, or press Alt+F3
2. Click more actions
3. Click "No Border" checkbox

OBSERVED RESULT
Window appears informing you that the only way to access the window decorations again is to press Alt+F3, with a checkbox that says "altf3warning", which prevents the window from opening again the next time you click "No Border"

EXPECTED RESULT
Window appears informing you that the only way to access the window decorations again is to press Alt+F3, with a checkbox that says "Do not show this box again" or similar message

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
Solus 4.1
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.72.0
Qt Version: 5.14.2
Comment 1 Nate Graham 2020-08-18 18:25:09 UTC
Ugh this thing builds up a list of args and pipes them into kdialog instead of using the KMessageBox API, how horrible. The bug is that the order and number of args differs depending on the way kdialog is called, and it's not matching up.

The best solution would be to port to using KMessageBox. Good junior job.

https://invent.kde.org/plasma/kwin/-/blob/master/useractions.cpp#L194
Comment 2 Christoph Feck 2020-08-18 22:56:29 UTC
KWin uses kdialog to run the window in a separate process; kwin itself cannot open a window.
Comment 3 Felipe Kinoshita 2022-07-01 03:33:05 UTC
This doesn't seem to be the case anymore, can anyone check?
Comment 4 Nate Graham 2022-07-01 13:41:49 UTC
Can confirm that it's fixed now.