Bug 425291 - Cannot click link under text markup
Summary: Cannot click link under text markup
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: PDF backend (show other bugs)
Version: 1.10.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-13 11:56 UTC by newptcai
Modified: 2020-09-22 00:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Example PDF file (262.05 KB, application/pdf)
2020-08-14 13:23 UTC, newptcai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description newptcai 2020-08-13 11:56:47 UTC
SUMMARY


STEPS TO REPRODUCE
1. Open a PDF with hyper links.
2. Annotate the pdf by adding a text markup on the line with the link
3. Try click the link

OBSERVED RESULT

The cursor does not change to the shape of a hand with a finger pointing at the link. Click the link does not do anything.

EXPECTED RESULT

Text markup should not stop clicking a link in a PDF.

SOFTWARE/OS VERSIONS
Linux: Ubuntu 18.04
Comment 1 Albert Astals Cid 2020-08-13 21:01:39 UTC
Can you attach a file where you can reproduce the problem?
Comment 2 newptcai 2020-08-14 13:23:47 UTC
Created attachment 130870 [details]
Example PDF file

Please check page one of this document.
Comment 3 Albert Astals Cid 2020-08-15 17:39:11 UTC
yep, i was sure we had a unitest to make sure that worked, but clearly not :/
Comment 4 Albert Astals Cid 2020-09-22 00:02:22 UTC
Git commit 3f89246317ecbf2b2c19a4c4416583db72d463bd by Albert Astals Cid.
Committed on 21/09/2020 at 23:30.
Pushed by aacid into branch 'release/20.08'.

Show "Follow link" if right clicking over link and annotation

Unite handling of right click in mouse release event

Before we had handling on press -> show annot menu if annot
and in release -> show link menu if link or show the genericmenu if nothing

Now we do everything on release and do
show link and annot menu if both
show link menu if link
show annot menu if annot
show generic menu if nothing

It helps with the fact that you can't click on links if there's an
annotation on top, which is a bit of a pain but it makes sense since
annotations usually have more interaction than links, you can select,
move, etc. them

M  +26   -29   ui/pageview.cpp

https://invent.kde.org/graphics/okular/commit/3f89246317ecbf2b2c19a4c4416583db72d463bd