Bug 425288 - D&D a frame to a Background layer with color as default pixel creates artifacts
Summary: D&D a frame to a Background layer with color as default pixel creates artifacts
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: 4.3.0
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Emmet O'Neill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-13 10:49 UTC by Dmitry Kazakov
Modified: 2020-09-02 22:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (135.74 KB, image/png)
2020-08-13 10:49 UTC, Dmitry Kazakov
Details
test file (365.66 KB, application/zip)
2020-08-13 10:49 UTC, Dmitry Kazakov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Kazakov 2020-08-13 10:49:29 UTC
Created attachment 130844 [details]
screenshot

STEPS TO REPRODUCE
1. Create an image with two layers. Choose "background as raster layer"
2. Create some frames on the second layer and paint on them
3. D&D one frame onto the background layer

OBSERVED RESULT

There is a white border artifacts around the pasted object. See attached screenshot and test file.
Comment 1 Dmitry Kazakov 2020-08-13 10:49:59 UTC
Created attachment 130845 [details]
test file
Comment 2 Ahab Greybeard 2020-08-13 18:32:43 UTC
I can confirm this for the Aug12 4.3.1 alpha (git dbf8a5d) appimage.

The artifact is a transparent rectangle surrounding the D&D content and larger that its bounding box.

If the Background layer is locked then the D&D frame is still moved to the Background frame.

An identically sized artifact can be produced for a non-animated layer above a Background layer by setting the content layer blending mode to Copy. (This is a separate bug that has not been reported at the time of this comment.)
Comment 3 Ahab Greybeard 2020-08-13 18:49:07 UTC
The Copy blending mode artifact referred to in Comment 2 has been reported:
https://bugs.kde.org/show_bug.cgi?id=425318
Comment 4 Eoin O'Neill 2020-09-02 20:31:27 UTC
Git commit 8a5e90a9b708da17abeff0c38a92ab873e9a61fc by Eoin O'Neill.
Committed on 02/09/2020 at 20:20.
Pushed by eoinoneill into branch 'master'.

Frame Drag and Drop Default Pixel Correction

When uploading a frame to dstData (KisPaintDeviceData), we should
make sure that the defaultPixel between the two are equivalient
and rectify the issue if they do not match.

M  +12   -0    libs/image/kis_paint_device.cc

https://invent.kde.org/graphics/krita/commit/8a5e90a9b708da17abeff0c38a92ab873e9a61fc
Comment 5 Eoin O'Neill 2020-09-02 22:32:47 UTC
Git commit 414ccc726cb5dbc89d7d88a43016fa86b0f5f5a9 by Eoin O'Neill.
Committed on 02/09/2020 at 22:28.
Pushed by eoinoneill into branch 'krita/4.3'.

Frame Drag and Drop Default Pixel Correction

When uploading a frame to dstData (KisPaintDeviceData), we should
make sure that the defaultPixel between the two are equivalient
and rectify the issue if they do not match.
(cherry picked from commit 8a5e90a9b708da17abeff0c38a92ab873e9a61fc)

M  +12   -0    libs/image/kis_paint_device.cc

https://invent.kde.org/graphics/krita/commit/414ccc726cb5dbc89d7d88a43016fa86b0f5f5a9