Bug 425255 - Since update to 5.73 some plasmoid action icons are way too big
Summary: Since update to 5.73 some plasmoid action icons are way too big
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.73.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords: regression
: 425541 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-08-12 13:11 UTC by Christian (Fuchs)
Modified: 2020-08-21 15:58 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/plasma-framework/commit/f857da38643ce143826580d3641a13b656676891
Version Fixed In: 5.74

Attachments
size differences (159.68 KB, image/png)
2020-08-12 13:11 UTC, Christian (Fuchs) 		Details
padding (33.05 KB, image/png)
2020-08-12 13:38 UTC, Christian (Fuchs) 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2020-08-12 13:11:36 UTC 
Created attachment 130819 [details]
size differences

SUMMARY

Since updating to frameworks 5.73, some (but not all) plasmoid action icons are now roughly twice the size as they used to be. 

See the attached screenshots for examples.
This includes plasmoids  (most right one in the attached image) that use plasma 2 components and have not been updated / changed in a while.

Frameworks 5.73
Qt 5.14.2
Plasma 5.19.4
X11, no scaling
Comment 1 Christian (Fuchs) 2020-08-12 13:38:19 UTC 
Created attachment 130820 [details]
padding

It appears that the buttons have the same size, just some have a padding (which makes the icon a bit smaller) whilst others have none, so the icon is the exact size of the button. See the new attachment.

I tried with both breeze and a custom theme which has not been updated, the issue stays the same.
Comment 2 Nate Graham 2020-08-12 13:59:12 UTC 
Will investigate.
Comment 3 Janet Blackquill 2020-08-12 21:26:13 UTC 
Can reproduce.
Comment 4 Bug Janitor Service 2020-08-13 00:44:33 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/66
Comment 5 Noah Davis 2020-08-13 21:13:17 UTC 
Git commit 7062c635a9bc7186af5d14037ba74cb527bf6386 by Noah Davis.
Committed on 13/08/2020 at 21:10.
Pushed by ndavis into branch 'master'.

Fix PC2 ToolButtonStyle margins

Previously, it was trying to use the margins of toolbutton-hover for flat buttons, but toolbutton-hover doesn't have real margins (0.001 since 0 isn't valid).

M  +4    -4    src/declarativeimports/plasmastyle/ToolButtonStyle.qml

https://invent.kde.org/frameworks/plasma-framework/commit/7062c635a9bc7186af5d14037ba74cb527bf6386
Comment 6 Noah Davis 2020-08-14 20:23:55 UTC 
Git commit f857da38643ce143826580d3641a13b656676891 by Noah Davis.
Committed on 14/08/2020 at 20:20.
Pushed by ndavis into branch 'master'.

Fix toolbutton-hover margins in button.svg

The toolbutton-hover margins need to be inconsistent with the hover margins because 3rd party themes expect this inconsistent behavior now.

M  +10   -10   src/desktoptheme/breeze/widgets/button.svg

https://invent.kde.org/frameworks/plasma-framework/commit/f857da38643ce143826580d3641a13b656676891
Comment 7 Nate Graham 2020-08-21 15:58:19 UTC 
*** Bug 425541 has been marked as a duplicate of this bug. ***