Bug 425218 - Stamp-based brushes are broken
Summary: Stamp-based brushes are broken
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: 4.3.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords: regression, release_blocker
Depends on:
Blocks:
 
Reported: 2020-08-11 12:26 UTC by Halla Rempt
Modified: 2020-08-12 09:21 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/graphics/krita/commit/3b7652d1a5278ea1daf778c1fdca2865170da9e0
Version Fixed In:

Attachments
screenshot (193.89 KB, image/png)
2020-08-11 12:26 UTC, Halla Rempt 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Halla Rempt 2020-08-11 12:26:01 UTC 
Created attachment 130781 [details]
screenshot

Both in master and in 4.3, stamp based brushes like z) Stamp Water or j)Waterpaint Hard Edges are broken; each stamp is painted opaquely.
Comment 1 wolthera 2020-08-12 09:09:07 UTC 
Might be fixed by this? https://invent.kde.org/graphics/krita/-/merge_requests/465
Comment 2 Halla Rempt 2020-08-12 09:20:17 UTC 
Yes, it does.
Comment 3 Halla Rempt 2020-08-12 09:21:43 UTC 
Git commit 3b7652d1a5278ea1daf778c1fdca2865170da9e0 by Boudewijn Rempt, on behalf of Peter Schatz.
Committed on 12/08/2020 at 09:21.
Pushed by rempt into branch 'master'.

Fix animated mask brushes

Due to changes in how brushes are represented internally and how they are
loaded, animated mask brushes would initially load as animated image brushes,
and draw incorrectly.  This fixes how they are loaded.

(cherry picked from commit ee1d9bb6a03e43b33ee531aa538bc1c8ff6e712d)

M  +2    -2    libs/brush/kis_predefined_brush_factory.cpp

https://invent.kde.org/graphics/krita/commit/3b7652d1a5278ea1daf778c1fdca2865170da9e0