Bug 425174 - global menu widget doesn't have padding between sections
Summary: global menu widget doesn't have padding between sections
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Menu (show other bugs)
Version: 5.19.4
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
: 425480 426392 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-08-10 01:19 UTC by nocentinigabriele91
Modified: 2020-11-08 05:39 UTC (History)
11 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/plasma-framework/commit/7574eee24e38c3e0e327a51a7e9828f518403e58
Version Fixed In: 5.74
Sentry Crash Report:

Attachments
global menu image (16.38 KB, image/jpeg)
2020-08-10 01:19 UTC, nocentinigabriele91 		Details
Global Menu Bug (100.32 KB, image/png)
2020-08-29 23:54 UTC, Siddhartha 		Details
Global Menu Bug V2 (73.73 KB, image/png)
2020-08-30 00:58 UTC, Siddhartha 		Details
"old" menubar (265.62 KB, image/png)
2020-11-08 05:38 UTC, joey.joey586 		Details
"fixed" menubar (219.44 KB, image/png)
2020-11-08 05:39 UTC, joey.joey586 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description nocentinigabriele91 2020-08-10 01:19:02 UTC 
Created attachment 130744 [details]
global menu image

SUMMARY
As showed in the image, the global menu widget doesn't have panning between sections. This artifact appeard after an update of kde components

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT
No spacing between sections in the global menu

EXPECTED RESULT
Proper spacing

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
Operating System: Arch Linux
KDE Plasma Version: 5.19.4
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0
Kernel Version: 5.7.12-arch1-1
OS Type: 64-bit
Processors: 2 × AMD Athlon(tm) 64 X2 Dual Core Processor 4200+
Memory: 1.9 GiB of RAM
Graphics Processor: AMD RV610

ADDITIONAL INFORMATION
Comment 1 D. Debnath 2020-08-16 03:34:00 UTC 
I can confirm this. See this reddit thread:

https://www.reddit.com/r/kde/comments/i8tvq7/global_menu_padding_broken/
Comment 2 Nicolas Fella 2020-08-18 07:16:44 UTC 
*** Bug 425480 has been marked as a duplicate of this bug. ***
Comment 3 Nicolas Fella 2020-08-18 11:14:34 UTC 
I can confirm this behaviour on Plasma 5.19

On current master however the opposite happens, Breeze looks fine but other themes (that are not descrendants of Breeze) lack padding.

It boils down to Plasmacomponents3's ToolButton padding, which is controlled by the Plasma theme. Some themes (such as Breeze) have paddings around their ToolButtons, others (such as Air) don't. Whether that's a regression in the theme engine or the theme's fault is out of my expertise to judge
Comment 4 Noah Davis 2020-08-21 17:31:55 UTC 
Git commit 7574eee24e38c3e0e327a51a7e9828f518403e58 by Noah Davis.
Committed on 20/08/2020 at 23:33.
Pushed by ndavis into branch 'master'.

Unify the flat/normal behavior of PC3 Buttons/ToolButtons

Rather than duplicating the behaviors in both Button.qml and ToolButton.qml, leading to bugs and inconsistencies, the Button/ToolButton background code is split into separate reusable files. The correct background is used depending on whether or not flat mode is enabled.

M  +19   -49   src/declarativeimports/plasmacomponents3/Button.qml
M  +19   -60   src/declarativeimports/plasmacomponents3/ToolButton.qml
A  +90   -0    src/declarativeimports/plasmacomponents3/private/ButtonBackground.qml     [License: LGPL(v2.0+)]
A  +81   -0    src/declarativeimports/plasmacomponents3/private/ButtonFocus.qml     [License: LGPL(v2.0+)]
A  +85   -0    src/declarativeimports/plasmacomponents3/private/ButtonHover.qml     [License: LGPL(v2.0+)]
M  +39   -64   src/declarativeimports/plasmacomponents3/private/ButtonShadow.qml
A  +194  -0    src/declarativeimports/plasmacomponents3/private/FlatButtonBackground.qml     [License: LGPL(v2.0+)]
A  +216  -0    src/declarativeimports/plasmacomponents3/private/RaisedButtonBackground.qml     [License: LGPL(v2.0+)]
M  +5    -1    src/declarativeimports/plasmacomponents3/private/qmldir

https://invent.kde.org/frameworks/plasma-framework/commit/7574eee24e38c3e0e327a51a7e9828f518403e58
Comment 5 Siddhartha 2020-08-29 23:53:53 UTC 
Does not seem to have fixed it for me. I get the same layout as originally reported, and clicking on a menu item deforms it even further. Attaching screenshot.

Operating System: Arch Linux
KDE Plasma Version: 5.19.80 (git master compiled today)
KDE Frameworks Version: 5.74.0 (plasma-framework-git r15542.8c37d1d22)
Qt Version: 5.15.0
Kernel Version: 5.8.5-arch1-1
Comment 6 Siddhartha 2020-08-29 23:54:50 UTC 
Created attachment 131275 [details]
Global Menu Bug
Comment 7 Nicolas Fella 2020-08-30 00:40:27 UTC 
Run rm .cache/plasma-svgelements-* and try again
Comment 8 Siddhartha 2020-08-30 00:58:51 UTC 
Created attachment 131277 [details]
Global Menu Bug V2

Thanks, now I get back an older bug, where the items don't have any padding at the bottom, as shown in the screenshot.
Comment 9 Noah Davis 2020-08-30 07:32:53 UTC 
This should fix the issue with the text: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/79
Comment 10 Siddhartha 2020-08-30 07:57:59 UTC 
Thanks a lot, Noah!
Comment 11 Nate Graham 2020-09-15 16:03:52 UTC 
*** Bug 426392 has been marked as a duplicate of this bug. ***
Comment 12 joey.joey586 2020-11-08 05:37:38 UTC 
Might be worth pointing out that the "fixed" menubar is slightly more compact than the original. Not sure whether its intentional but i'm gonna point it out, just in case
Comment 13 joey.joey586 2020-11-08 05:38:48 UTC 
Created attachment 133128 [details]
"old" menubar
Comment 14 joey.joey586 2020-11-08 05:39:20 UTC 
Created attachment 133129 [details]
"fixed" menubar