Bug 425161 - Default keyboard shortcut for adding attachments
Summary: Default keyboard shortcut for adding attachments
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-09 13:42 UTC by Thiago Sueto
Modified: 2020-09-03 06:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Sueto 2020-08-09 13:42:54 UTC
Hello, it would be awesome to have a default keyboard shortcut for adding attachments. KMail has a great mail composer in terms of keyboard shortcuts, but the only default way of adding an attachment is by accelerator keys (Alt+A+A).
Comment 1 Laurent Montel 2020-08-22 16:34:52 UTC
Which shortcut do you think that it can be useful ?
Comment 2 Thiago Sueto 2020-08-24 13:54:48 UTC
I'll verify the current ones later and I'll make an attempt at that.
Comment 3 Thiago Sueto 2020-09-02 15:03:35 UTC
Ctrl+key wouldn't work quite nicely due to the lack of keys that could be easily associated to Attachment, unlike most Kontact keyboard shortcuts which are well thought out.

I think Ctrl+Alt+A would be fine, considering Plasma is transitioning to using using Meta/Super/Windows for system and desktop keyboard shortcuts.

There are precedents for Ctrl+Alt+firstletter in KMail, the composer, and Kontact, whereas Ctrl+Shift+firstletter is more related to standardized shortcuts (Ctrl+Shift+Z = redo) or to selection/tabs.

Weirdly enough, when I attempted to set Ctrl+Alt+A, it didn't work. I assume this is because Plasma already has Ctrl+Alt+A for a default shortcut (activate window demanding attention), so Ctrl+Shift+A might be more suitable to avoid conflicts.
Comment 4 Laurent Montel 2020-09-03 06:05:20 UTC
Git commit 6074ec194aee70baededfd3090cfe880b4b9a4c8 by Laurent Montel.
Committed on 03/09/2020 at 06:04.
Pushed by mlaurent into branch 'release/20.08'.

Fix Bug 425161 - Default keyboard shortcut for adding attachments
FIXED-IN: 5.15.2

M  +1    -0    messagecomposer/src/attachment/attachmentcontrollerbase.cpp

https://invent.kde.org/pim/messagelib/commit/6074ec194aee70baededfd3090cfe880b4b9a4c8