Bug 425117 - Combine "Halt" and "Continue" button
Summary: Combine "Halt" and "Continue" button
Status: RESOLVED FIXED
Alias: None
Product: print-manager
Classification: Frameworks and Libraries
Component: applet (show other bugs)
Version: 20.04
Platform: Other Other
: NOR wishlist
Target Milestone: ---
Assignee: Daniel Nicoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-07 17:10 UTC by postix
Modified: 2020-08-16 11:54 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.12.0
Sentry Crash Report:


Attachments
Screenshot (77.06 KB, image/png)
2020-08-07 17:10 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-08-07 17:10:01 UTC
Created attachment 130714 [details]
Screenshot

There are currently the following buttons in the toolbar:

Cancel | Hold Continue "Print Again" "Current Jobs"

"Continue" only becomes active if "Hold" was pressed and vice versa.
This means one button can be spared, increasing the available space and overall clearness.

"Hold" would become "Continue" and vice versa. This should not create confusion, as the applet's top caption already informs about the current state: "Printer ready" and "[Document name] is being printed".
Comment 1 postix 2020-08-07 17:12:03 UTC
Also, it's a little bit confusing to have two buttons for "Continue printing" and "halt printer" which both seem to serve the same purpose:

The both on top and those in the toolbar.
Comment 3 postix 2020-08-11 14:14:36 UTC
Thanks for submitting a patch so quickly. I thought about it again and I think the initial idea of two buttons were introduced for a multi selection of several print jobs:

#Print Job | Status
-------------------
1 | Hold
2 | In Progress


If one selected 1 and 2, it was possible to hold or resume both with a single click (on one of the two buttons).
Now one would press "hold" first and then probably "resume".

Question: In the situation described above, is "hold" the first status before "resume" becomes available with the new patch? I think this would make sense to not accidentally start a print job.

I'd be fine with this situation. Just wanted to point it out again if it wasn't obvious already. :)
Comment 4 Jan Paul Batrina 2020-08-16 11:54:33 UTC
Hello, I was the one who submitted the patch.

I also was worried about how to handle multiple jobs, but the change I made was mostly cosmetic (code wise) so the previous behavior is retained (i.e. both hold and resume show when multiple jobs with differing statuses are selected).

Yes, hold is the initially activated button and resume only shows when a job (or one in a bunch) is selected.

One side effect though is that when no jobs are selected, neither of Hold and Resume are visible, so that might hurt the discoverability a bit.