Bug 425107 - Settings window of applet/widget inappropriately prompts to save/discard changes when moving from keyboard tab to about tab
Summary: Settings window of applet/widget inappropriately prompts to save/discard chan...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (other bugs)
Version First Reported In: master
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-07 12:21 UTC by Patrick Silva
Modified: 2020-08-14 08:10 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/commit/9aa7f986a2428073eb2c5d6397454689432f8113
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-08-07 12:21:43 UTC 
SUMMARY
I can reproduce with the following applets/widget on my system:
Notifications
Media Player
Vaults
Minimize all windows/Show desktop

STEPS TO REPRODUCE
1. open the settings window of any applet/widget mentioned above
2. click on "About" in the left side
3. 

OBSERVED RESULT
save/discard dialog shows up

EXPECTED RESULT
no dialog because nothing was changed

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.19.80
KDE Frameworks Version: 5.73.0
Qt Version: 5.14.2
Comment 1 Patrick Silva 2020-08-07 12:24:55 UTC 
Display Configuration applet is also affected.
Comment 2 Nate Graham 2020-08-10 15:54:58 UTC 
Can also confirm.
Comment 3 David Redondo 2020-08-11 06:45:55 UTC 
Weird, the keyboard page thinks it has unsaved changes, apply is also enabled.
Comment 4 Bug Janitor Service 2020-08-11 12:01:40 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/103
Comment 5 David Redondo 2020-08-14 08:10:27 UTC 
Git commit 9aa7f986a2428073eb2c5d6397454689432f8113 by David Redondo.
Committed on 14/08/2020 at 08:08.
Pushed by davidre into branch 'master'.

Use captureFinished signal

KeySequence change can be trigered on initial load and the dialog thinks there
are unsaved changes.

M  +1    -1    desktoppackage/contents/configuration/ConfigurationShortcuts.qml

https://invent.kde.org/plasma/plasma-desktop/commit/9aa7f986a2428073eb2c5d6397454689432f8113