Bug 425059 - Missing symlinks for audio/mpeg (mp3) files
Summary: Missing symlinks for audio/mpeg (mp3) files
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: 5.19.2
Platform: Other Other
: NOR minor
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-06 03:13 UTC by Alex
Modified: 2020-09-29 23:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.74


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2020-08-06 03:13:02 UTC
SUMMARY
Breeze doesn't handle the audio/mpeg mimetype, which is what mp3 files are detected as on my system.

STEPS TO REPRODUCE
1. Open Dolphin
2. Navigate to a folder containing mp3 files

OBSERVED RESULT
Generic audio icon is shown for mp3 files.

EXPECTED RESULT
The icon for audio/x-mpeg is shown for mp3 files.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.19.2
KDE Frameworks Version: 5.71.0
Qt Version: 5.15.0
Comment 1 Nate Graham 2020-08-06 21:15:07 UTC
Git commit 7049bd07ebd4e52af2119eff55bcd5343be1876f by Nate Graham.
Committed on 06/08/2020 at 21:13.
Pushed by ngraham into branch 'master'.

Add aliases for MP3 icons

Now MP3 audio files with the `audio/mpeg` mimetype get the right icon.
FIXED-IN: 5.74

A  +1    -0    icons-dark/mimetypes/16/audio-mpeg.svg
A  +1    -0    icons-dark/mimetypes/22/audio-mpeg.svg
A  +1    -0    icons-dark/mimetypes/32/audio-mpeg.svg
A  +1    -0    icons-dark/mimetypes/64/audio-mpeg.svg
A  +1    -0    icons/mimetypes/16/audio-mpeg.svg
A  +1    -0    icons/mimetypes/22/audio-mpeg.svg
A  +1    -0    icons/mimetypes/32/audio-mpeg.svg
A  +1    -0    icons/mimetypes/64/audio-mpeg.svg

https://invent.kde.org/frameworks/breeze-icons/commit/7049bd07ebd4e52af2119eff55bcd5343be1876f
Comment 2 Nate Graham 2020-08-06 21:15:52 UTC
Thanks for the very clear bug report!
Comment 3 Alex 2020-08-07 00:18:03 UTC
(In reply to Nate Graham from comment #2)
> Thanks for the very clear bug report!

Thanks for the quick fix! :)

I also noticed the same issue with gzip files (detected as application/gzip and shown as generic package icon), could you please add the below link as well?

application/gzip -> application/x-gzip
Comment 4 Nate Graham 2020-08-07 15:31:41 UTC
Git commit a18d1ced8cbfa30a6b4f21417655293ae99844d3 by Nate Graham.
Committed on 07/08/2020 at 15:29.
Pushed by ngraham into branch 'master'.

Make application-gzip symlink to application-x-gzip

A  +1    -0    icons-dark/mimetypes/16/application-gzip.svg
A  +1    -0    icons-dark/mimetypes/22/application-gzip.svg
A  +1    -0    icons-dark/mimetypes/32/application-gzip.svg
A  +1    -0    icons-dark/mimetypes/64/application-gzip.svg
A  +1    -0    icons/mimetypes/16/application-gzip.svg
A  +1    -0    icons/mimetypes/22/application-gzip.svg
A  +1    -0    icons/mimetypes/32/application-gzip.svg
A  +1    -0    icons/mimetypes/64/application-gzip.svg

https://invent.kde.org/frameworks/breeze-icons/commit/a18d1ced8cbfa30a6b4f21417655293ae99844d3
Comment 5 Nate Graham 2020-08-07 15:31:57 UTC
Done! :)
Comment 6 Patrick Silva 2020-09-17 22:57:19 UTC
icons of mp3 files look th same on my system after update to frameworks 5.74.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.19.90
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.1
Comment 7 Nate Graham 2020-09-18 01:10:57 UTC
Works for me with my MP3 files which have the mimetype "audio/mpeg"; I see the nice purple icon. Can you run `file --mime-type <path to file>` on one of the files with the wrong icon?
Comment 8 Patrick Silva 2020-09-29 23:50:12 UTC
humm, apparently my system was not affected by this bug before update to frameworks 5.74 then. I see purple icons too. 

Testing a file here:
$file --mime-type 01.\ Thunderstruck.mp3 
01. Thunderstruck.mp3: audio/mpeg