Bug 424967 - kdenlive doesn't load its translations
Summary: kdenlive doesn't load its translations
Status: RESOLVED WORKSFORME
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (other bugs)
Version First Reported In: unspecified
Platform: openSUSE Other
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-03 17:51 UTC by Christophe Marin
Modified: 2021-04-30 04:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:
fritzibaby: timeline_corruption+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Marin 2020-08-03 17:51:07 UTC
I received a private message after packaging kdenlive 20.07.90 about the interface not being localized.

Even changing the primary language has no effect.

The only relevant entry when running kdenlive is:
19:34:44 - kdenlive(14226) -  unknown: LC_ALL reset to C
Comment 1 Jean-Baptiste Mardelle 2020-08-03 19:25:55 UTC
Git commit 143bf1697e84bfca3967535dcaa1e96a92f5cdc1 by Jean-Baptiste Mardelle.
Committed on 03/08/2020 at 19:25.
Pushed by mardelle into branch 'master'.

Attempt to fix UI translations broken.

M  +6    -6    src/lib/localeHandling.cpp

https://invent.kde.org/multimedia/kdenlive/commit/143bf1697e84bfca3967535dcaa1e96a92f5cdc1
Comment 2 Jean-Baptiste Mardelle 2020-08-03 19:29:35 UTC
Ouch, thanks for the report. This indeed seems a regression caused by a change to solve a numerical separator issue we encountered when working with project files in several locales. We are testing a fix and will get back to you asap
Comment 3 Christophe Marin 2020-08-03 19:57:21 UTC
I switched the interface to french, I can load an old project, save it
Comment 4 Jean-Baptiste Mardelle 2020-08-03 20:11:33 UTC
Git commit 5aa1aea64e5084dc97cbd4ae8c02482fc53948ce by Jean-Baptiste Mardelle.
Committed on 03/08/2020 at 20:11.
Pushed by mardelle into branch 'release/20.08'.

Attempt to fix UI translations broken.

M  +6    -6    src/lib/localeHandling.cpp

https://invent.kde.org/multimedia/kdenlive/commit/5aa1aea64e5084dc97cbd4ae8c02482fc53948ce
Comment 5 Jean-Baptiste Mardelle 2020-08-03 20:12:55 UTC
Thanks for your confirmation. I just pushed the fix in 20.08 branch and our team will make more tests tomorrow to confirm this doesn't cause regressions.
Comment 6 Christophe Marin 2020-08-04 14:25:33 UTC
The downstream reporter confirms the patch works for him. The only remaining issue we noticed is the locale cache.

I tried changing kdenlive's language to german, then back to english but some menu entries were still localized.
Comment 7 Julius Künzel 2021-03-31 14:03:44 UTC
Can you please retest with version 20.12.3? If there are still problems please check if they are similar to this report https://bugs.kde.org/show_bug.cgi?id=434179 (the problems there are fixed for 21.04 coming in April)
Comment 8 Bug Janitor Service 2021-04-15 04:33:21 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 9 Bug Janitor Service 2021-04-30 04:33:44 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!