Bug 424904 - No more keyboard shortcuts
Summary: No more keyboard shortcuts
Status: RESOLVED NOT A BUG
Alias: None
Product: kphotoalbum
Classification: Applications
Component: general (show other bugs)
Version: 5.6.1
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: KPhotoAlbum Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-01 19:05 UTC by Alex6
Modified: 2020-08-05 21:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
attachment-2772-0.html (4.82 KB, text/html)
2020-08-03 14:59 UTC, Alex6
Details
attachment-18283-0.html (3.31 KB, text/html)
2020-08-05 09:43 UTC, Alex6
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex6 2020-08-01 19:05:52 UTC
No more shortcuts personnalization possible.
Some shortcuts are "hard"coded (ex: Left, Right) and taboo
Others established are forgotten by next kph startup.


STEPS TO REPRODUCE: see above

OBSERVED RESULT
No configurable keyboard shortcuts

EXPECTED RESULT



Linux/KDE Plasma: 

KDE Plasma Version: 5.19.3
KDE Frameworks Version: 5.72.0
Qt Version: 5.15.0
Comment 1 Johannes Zarl-Zierl 2020-08-02 22:27:00 UTC
Hi Alex,

Thanks for your problem report.

I see two separate issues: It's correct that some keyboard shortcuts (like left/right for previous/next image) are hard-coded. Up until now this was "good enough", but that doesn't mean that it cannot be changed. I'm happy to put this on the list of requested features...

The other issue is about shortcut configuration being forgotten between startups.
I could not reproduce this with kphotoalbum 5.6.1 and the current git version (on Debian unstable, with Plasma 5.17, KF5 5.70, Qt 5.14).
Shortcuts are stored in the file kphotoalbumui.rc, which is usually located in the directory "$HOME/.local/share/kxmlgui5/kphotoalbum/". Could you backup this file, change a shortcut and then see if there are any changed made to it?

Cheers,
  Johannes
Comment 2 Alex6 2020-08-03 14:59:23 UTC
Created attachment 130608 [details]
attachment-2772-0.html

Le lundi 3 août 2020 00:27:00 CEST, vous avez écrit :
> https://bugs.kde.org/show_bug.cgi?id=424904
> 
> Johannes Zarl-Zierl <johannes@zarl-zierl.at> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |johannes@zarl-zierl.at
> 
> --- Comment #1 from Johannes Zarl-Zierl <johannes@zarl-zierl.at> ---
> Hi Alex,
> 
> Thanks for your problem report.
> 
> I see two separate issues: It's correct that some keyboard shortcuts (like
> left/right for previous/next image) are hard-coded. Up until now this was "good
> enough", but that doesn't mean that it cannot be changed. I'm happy to put this
> on the list of requested features...
> 
> The other issue is about shortcut configuration being forgotten between
> startups.
> I could not reproduce this with kphotoalbum 5.6.1 and the current git version
> (on Debian unstable, with Plasma 5.17, KF5 5.70, Qt 5.14).
> Shortcuts are stored in the file kphotoalbumui.rc, which is usually located in
> the directory "$HOME/.local/share/kxmlgui5/kphotoalbum/". Could you backup this
> file, change a shortcut and then see if there are any changed made to it?
> 
> Cheers,
>   Johannes
> 
Danke für schnelle Antwort!
Issue 1: ok... universal configurability is for me better...
Issue 2: nur "ok" geclickt, hatte nicht "schemes->more actions->save shortcuts to scheme" bemerkt...  ein bisschen kompliziert? und wer will mehr als ein "scheme" per user nützen?

Mit freundlichen Grüssen,
Alex
Comment 3 Johannes Zarl-Zierl 2020-08-03 19:01:17 UTC
Hallo Alex,

(Keeping the reply in English for the benefit of potential readers)

I'm glad you found the "schemes->more actions->save shortcuts to scheme" workaround. It should not be necessary, though.

Does changing the shortcut work without explicit saving in other KDE applications?

Cheers,
  Johannes
Comment 4 Alex6 2020-08-05 09:43:25 UTC
Created attachment 130656 [details]
attachment-18283-0.html

Le lundi 3 août 2020 21:01:17 CEST, vous avez écrit :
> https://bugs.kde.org/show_bug.cgi?id=424904
> 
> --- Comment #3 from Johannes Zarl-Zierl <johannes@zarl-zierl.at> ---
> Hallo Alex,
> 
> (Keeping the reply in English for the benefit of potential readers)
> 
> I'm glad you found the "schemes->more actions->save shortcuts to scheme"
> workaround. It should not be necessary, though.
> 
> Does changing the shortcut work without explicit saving in other KDE
> applications?
> 
> Cheers,
>   Johannes
> 
Hello,
Changing a shortcut and click "ok" works only if no scheme exists, in kpa as in other KDE apps.
In KDE shortcut settings dialog, there is no indication that a scheme is used nor default scheme, that is a bit confusing...
Save a new shortcut with Manage Schemes->More Actions->Save Shortcuts to Scheme is for me a bit confusing and complicated too!
Shortcuts modifying is normally not a daily task!!!
But this is a KDE, not Kpa problem, excuse me for this false bug.

... But why "hard-coded" shortcuts in Kpa, totally configurable sc would be better?

Thanks for all
Cheers,
Alex
Comment 5 Johannes Zarl-Zierl 2020-08-05 21:09:02 UTC
Hi Alex,

Thanks for your analysis of the problem! I don't use shortcut schemes myself, so I didn't notice this peculiar behavior before.

For the "hard-coded shortcuts" issue, I've filed a separate wishlist item (bug #425055). In general, I agree with your sentiment that totally configurable shortcuts are better, but the devil lies in the details ;-)
I.e., most places where keyboard actions are hard-coded use a custom keyboard handler to provide additional actions. This makes it harder in those places to integrate the keyboard handling with the standard shortcut handling.
Anyways, the issue is now at least tracked, which increases the chances of it being fixed in the future considerably...

I'm closing this bug for now, since the core concern is not a bug in KPhotoAlbum itself...

Cheers,
  Johannes