Bug 424903 - Split Transaction with a tag displays as a deposit instead of payment under Tag view
Summary: Split Transaction with a tag displays as a deposit instead of payment under T...
Status: RESOLVED NOT A BUG
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 5.1.0
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
: 425808 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-08-01 19:05 UTC by ryan9590
Modified: 2020-08-26 07:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Tag View/Ledger view two images (54.17 KB, application/zip)
2020-08-01 19:05 UTC, ryan9590
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ryan9590 2020-08-01 19:05:11 UTC
Created attachment 130562 [details]
Tag View/Ledger view two images

SUMMARY

When I add a Tag to a split transaction, under Tag view it shows as a deposit instead of payment thus giving wrong balance. If I change to a ledger view then the proper values are shown and balance. If the Tag is not split, then it displays correctly as a payment respectively. 

STEPS TO REPRODUCE
1. Make transaction
2. Create split with Tag
3. View under Tags

OBSERVED RESULT
Wrong balance under tags

EXPECTED RESULT
Correct balance under tags

SOFTWARE/OS VERSIONS
Windows: n/a
macOS: n/a
Linux/KDE Plasma: Debian 10
(available in About System)
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3

ADDITIONAL INFORMATION
Comment 1 Jack 2020-08-01 19:37:52 UTC
This was recently discussed in a similar bug.  Whenever you view a ledger like display, it is important to be sure of the context.  Unfortunately, when viewing the ledger for a Category, the dropdown at the top is not updated to show the Category name, but still shows whatever Account was previously displayed in the ledger.  Whether a split is a deposit or withdrawal (payment or expense) depends on which side you are considering.  Especially with split transactions, Any withdrawal/expense from one of your accounts is a deposit/payment from the perspective of the Category.  In addition, the Tags View is showing all splits with that tag.  The Balance there is not very meaningful, as each split could be for an account or category, where the ins and outs do seem reversed.
If this doesn't explain it sufficiently, please provide a more concrete example naming all accounts, payees, and categories for all splits.  Also please be careful with terminology.  A transaction may be split, and a tag may be applied to a transaction or to a single split.  Tags are not split.
Thanks.
Comment 2 Jack 2020-08-01 19:38:27 UTC
Also - all of that said, perhaps we should not show a Balance on the Tag view, just for this reason.
Comment 3 ryan9590 2020-08-01 19:59:31 UTC
(In reply to Jack from comment #2)
> Also - all of that said, perhaps we should not show a Balance on the Tag
> view, just for this reason.

Thank you for explaining, my main use for tags was only to quickly find a set of transactions I need to compile later. The payment/deposit and balance threw me off; I would be okay with removing balance. Ledger view gets me what I need in terms of balance.
Comment 4 Thomas Baumgart 2020-08-21 08:39:08 UTC
Git commit b9510dc1644375873185e90ebd93e1378f6ab4c0 by Thomas Baumgart.
Committed on 20/08/2020 at 09:02.
Pushed by tbaumgart into branch 'master'.

Improve balance handling in tags view

When transactions are shown in the tags view that were extracted from
multiple accounts the balance displayed does not provide any useful
information.

This change will suppress the balance display in this case.

M  +4    -0    kmymoney/views/ktagsview.cpp

https://invent.kde.org/office/kmymoney/commit/b9510dc1644375873185e90ebd93e1378f6ab4c0
Comment 5 Thomas Baumgart 2020-08-26 07:21:31 UTC
*** Bug 425808 has been marked as a duplicate of this bug. ***