Bug 424835 - Logic errors and some trivial errors as reported by scan-build
Summary: Logic errors and some trivial errors as reported by scan-build
Status: RESOLVED UPSTREAM
Alias: None
Product: gcompris
Classification: Applications
Component: general (other bugs)
Version First Reported In: git master
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jazeix Johnny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-30 17:23 UTC by Avinash Sonawane
Modified: 2020-07-31 07:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Avinash Sonawane 2020-07-30 17:23:14 UTC 
Hello!

Scan-build[0] reported 3 logic errors along with other trivial errors. Here is the report: https://rootkea.gitlab.io/gcompris/scan-build/

Please take a look at them.

And here is the .gitlab-ci.yml which generated above report: https://gitlab.com/rootkea/gcompris/-/blob/gitlab-scan-build/.gitlab-ci.yml

Thanks!

[0] https://clang-analyzer.llvm.org/scan-build.html
Comment 1 Jazeix Johnny 2020-07-30 21:02:34 UTC 
Hi,

Thank you for reporting the issue.
These issues are in the submodule box2d we use and we don't have the hand to fix the issue.
You can report them if you want to the parent project: https://github.com/qml-box2d/qml-box2d but latest commit is from 2018...
Comment 2 Avinash Sonawane 2020-07-30 23:21:30 UTC 
Oh! I'm sorry I didn't even look at the source files been reported to know that the bugs were from qml-box2d. My bad!

Anyways, reported upstream. https://github.com/qml-box2d/qml-box2d/issues/126
Comment 3 Jazeix Johnny 2020-07-31 07:43:32 UTC 
(In reply to Avinash Sonawane from comment #2)
> Oh! I'm sorry I didn't even look at the source files been reported to know
> that the bugs were from qml-box2d. My bad!
>

No problem at all, better safe than sorry.
 
> Anyways, reported upstream. https://github.com/qml-box2d/qml-box2d/issues/126

Thank you.