Bug 424728 - Skrooge reconciliation should play happy sounds when delta is 0 and when you validate pointed operations
Summary: Skrooge reconciliation should play happy sounds when delta is 0 and when you ...
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: Trunk from git
Platform: Flatpak Linux
: NOR minor
Target Milestone: ---
Assignee: Guillaume DE BURE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-28 02:56 UTC by skierpage
Modified: 2020-08-09 13:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2020-07-28 02:56:52 UTC
SUMMARY
In reconciliation mode, it's easy to miss when the delta goes to 0 and a checkmark appears. Then when you click the checkmark to "validate pointed operations" it's a bit anticlimactic ;-) . Skrooge plays a sound for every operation update, but not for these happy occasions. FWIW, Quicken Deluxe plays a cash register sound effect when you complete reconciliation.

STEPS TO REPRODUCE
1. In Skrooge, go into reconciliation mode
2. Mark ("point") operations until marked transactions match the balance, so the delta is 0.
3. Click the checkmark to validate pointed operations.

OBSERVED RESULT
No sounds play.

EXPECTED RESULT
Happy sounds. Delta of 0 is not a guarantee that you've marked the right transactions, so it should be cautiously optimistic. Maybe use coin sound for the first, and a cash register ka-ching for the second.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2

ADDITIONAL INFORMATION
Wikimedia Commons is a good source of completely free sounds. It says its https://commons.wikimedia.org/wiki/File:Cash_register.ogg comes from http://soundbible.com/333-Cash-Register-Cha-Ching.html , but the latter is much shorter.

For coins, https://commons.wikimedia.org/wiki/File:Bag_of_coins.ogg is great but goes on and on, it would need an edit. The latter site has an overlong coin jingle that one could edit, or a shorter http://soundbible.com/2204-Poker-Chips.html
Comment 1 Stephane MANKOWSKI 2020-08-09 13:10:40 UTC
Git commit d0ace9bda34cb1fa5b467a350792285add35a6b7 by Stephane MANKOWSKI.
Committed on 09/08/2020 at 13:10.
Pushed by smankowski into branch 'master'.

Skrooge reconciliation should play happy sounds when delta is 0 and when you validate pointed operations

M  +5    -0    CHANGELOG
M  +2    -2    plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp

https://invent.kde.org/office/skrooge/commit/d0ace9bda34cb1fa5b467a350792285add35a6b7