Bug 424615 - Plasma SVG cache not regenerated when changing scale factor
Summary: Plasma SVG cache not regenerated when changing scale factor
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: 5.19.3
Platform: Other Other
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
: 396791 424587 436918 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-24 18:10 UTC by postix
Modified: 2022-09-08 13:38 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.74

Attachments
Screenshot (196.57 KB, image/png)
2020-07-24 18:10 UTC, postix 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2020-07-24 18:10:09 UTC 
Created attachment 130373 [details]
Screenshot

SUMMARY

The scrollbar's width has doubled, cf. screenshot.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.19.3
KDE Frameworks Version: 5.73.0
Qt Version: 5.15.0
Comment 1 Nate Graham 2020-07-24 18:14:38 UTC 
Cannot reproduce. Did you restart both plasmashell and KWin? Also try clearing the plasma SVG cache with `rm ~/.cache/plasma*` and then restarting plasmashell and KWin again.
Comment 2 postix 2020-07-24 18:23:40 UTC 
(In reply to Nate Graham from comment #1)
> Cannot reproduce. Did you restart both plasmashell and KWin? Also try
> clearing the plasma SVG cache with `rm ~/.cache/plasma*` and then restarting
> plasmashell and KWin again.

Flushing the cache alone solved it. :)
Comment 3 Nate Graham 2020-07-24 18:30:06 UTC 
Cool.

We should probably do that automatically. I had similar issues when changing the scale on Wayland where scrollbars were too wide after going rom one scale factor to another until I cleared the cache, so it doesn't even seem specific to X11 but rather to the use of Qt scaling (which is always used on Wayland).

Re-opening the bug and making it about that!
Comment 4 postix 2020-07-24 18:34:04 UTC 
Before you hold your breath, I really forgot to mention that I locked the screen (Ctrl+L) and unlocked it again, before I confirmed the solution. If that was kind of cheating, I may try to reproduce it again... O:-)
Comment 5 Nate Graham 2020-07-24 18:45:18 UTC 
Not cheating, I don't think that's related. :)
Comment 6 David Edmundson 2020-07-24 21:31:17 UTC 
>Re-opening the bug and making it about that!

Why do we need to flush the cache? Isn't the DPR encoded into the key?
Comment 7 Nate Graham 2020-07-24 22:37:35 UTC 
No idea. However it seems to be the case that when you change the scale factor, various things in the cache don't get marked dirty properly so it needs to be cleared.
Comment 8 Nate Graham 2020-07-25 00:04:42 UTC 
*** Bug 424587 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2020-07-25 00:05:55 UTC 
According to your WIP patch in https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/50, it is encoded into the ID incorrectly, which seems to match up with the symptoms of this bug.
Comment 10 David Edmundson 2020-07-25 11:53:46 UTC 
> which seems to match up with the symptoms of this bug.

Not a coincidence :)

If that fixes it, great. If it doesn't then we have more work to do on finding the remaining bugs. Flushing the cache is hiding a problem not fixing a problem, which is why I don't want the bug specifically about that to be open.

It would also break wayland where we support multiple at once.
Comment 11 Nate Graham 2020-08-24 19:49:02 UTC 
David's patch landed and now this is fixed!
Comment 12 Nate Graham 2021-03-20 02:53:07 UTC 
Seems like it did not fully fix it. Still sometimes reproducible. See Bug 396791.
Comment 13 Nate Graham 2022-06-05 18:40:09 UTC 
*** Bug 396791 has been marked as a duplicate of this bug. ***
Comment 14 Nate Graham 2022-06-05 18:40:13 UTC 
*** Bug 436918 has been marked as a duplicate of this bug. ***