Bug 424527 - Line chart Y range max value for system monitor widget is too small
Summary: Line chart Y range max value for system monitor widget is too small
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Monitor widgets (show other bugs)
Version: 5.20.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-22 07:01 UTC by Nicola Mori
Modified: 2021-02-26 09:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicola Mori 2020-07-22 07:01:44 UTC
SUMMARY
When using the Line Chart style for system monitor widget, the manual setting for the maximum value of the Y axis is too small (99,999). This makes it impossible e.g. to create a memory monitor widget with line style and fixed Y range, since memory values are reported in KiB and on a 16 GB system the maximum should be about 16,000,000.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Archlinux
(available in About System)
KDE Plasma Version: 5.19.3
KDE Frameworks Version: 5.72.0
Qt Version: 5.15.0
Comment 1 Nicola Mori 2020-09-02 06:22:21 UTC
In 5.19.4 and 5.19.5 the automatic Y range seems to somehow set a sane and fixed maximum value. However, the problem with the manual set of the maximum Y value persists.
Comment 2 Nicola Mori 2020-10-21 06:30:12 UTC
Still present in version 5.20.1. The maximum settable value is 99,999 which for the memory monitor widget corresponds to about 99 MB.
Comment 3 Nicola Mori 2020-10-28 07:50:28 UTC
Still present in 5.20.2 with frameworks 5.75.0.
Comment 4 Arjen Hiemstra 2021-02-24 12:19:31 UTC
Git commit 504dcbd225e26fe39f1f26d65ad477fc73558762 by Arjen Hiemstra.
Committed on 23/02/2021 at 15:27.
Pushed by ahiemstra into branch 'master'.

Set min/max for Y axis range spinboxes to minimum/maximum possible value

Some sensors have a range of gigabytes or terabytes, like memory and
disk. Since the base unit for these is bytes, we end up needing a very
large value in the range, which currently is not possible due to the
spinbox limiting the value. Internally, spinbox seems to use an int so
we can only store a value that fits within the range of an int, so we
use that as min/max value.

Longer term we want to have some ability to choose an actual "maximum"
sensor but that's going to need more work.
Related: bug 433007

M  +4    -4    faces/facepackages/barchart/contents/ui/Config.qml
M  +4    -4    faces/facepackages/linechart/contents/ui/Config.qml
M  +4    -2    faces/facepackages/piechart/contents/ui/Config.qml

https://invent.kde.org/plasma/libksysguard/commit/504dcbd225e26fe39f1f26d65ad477fc73558762
Comment 5 Arjen Hiemstra 2021-02-26 09:40:10 UTC
Git commit e01caf4fb1bb4245d1f1fdb20cf58a9695037628 by Arjen Hiemstra.
Committed on 26/02/2021 at 09:39.
Pushed by ahiemstra into branch 'Plasma/5.21'.

Set min/max for Y axis range spinboxes to minimum/maximum possible value

Some sensors have a range of gigabytes or terabytes, like memory and
disk. Since the base unit for these is bytes, we end up needing a very
large value in the range, which currently is not possible due to the
spinbox limiting the value. Internally, spinbox seems to use an int so
we can only store a value that fits within the range of an int, so we
use that as min/max value.

Longer term we want to have some ability to choose an actual "maximum"
sensor but that's going to need more work.
Related: bug 433007


(cherry picked from commit 504dcbd225e26fe39f1f26d65ad477fc73558762)

M  +4    -4    faces/facepackages/barchart/contents/ui/Config.qml
M  +4    -4    faces/facepackages/linechart/contents/ui/Config.qml
M  +4    -2    faces/facepackages/piechart/contents/ui/Config.qml

https://invent.kde.org/plasma/libksysguard/commit/e01caf4fb1bb4245d1f1fdb20cf58a9695037628