Bug 424471 - Sections of Kate settings are barely readable
Summary: Sections of Kate settings are barely readable
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: 20.07.80
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2020-07-20 15:24 UTC by Patrick Silva
Modified: 2020-09-28 15:26 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 20.12
Sentry Crash Report:


Attachments
screenshot (85.05 KB, image/png)
2020-07-20 15:24 UTC, Patrick Silva
Details
Enabled items (77.27 KB, image/png)
2020-07-21 16:17 UTC, Fernando Mattioli
Details
Selected item (51.24 KB, image/png)
2020-07-21 16:18 UTC, Fernando Mattioli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-07-20 15:24:03 UTC
Created attachment 130286 [details]
screenshot

SUMMARY
See the atacched screenshot please.

EXPECTED RESULT
better readbility

SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.19.3
KDE Frameworks Version: 5.72.0
Qt Version: 5.15.0
Comment 1 Fernando Mattioli 2020-07-21 16:17:57 UTC
Created attachment 130302 [details]
Enabled items
Comment 2 Fernando Mattioli 2020-07-21 16:18:26 UTC
Created attachment 130303 [details]
Selected item
Comment 3 Fernando Mattioli 2020-07-21 16:19:33 UTC
In kateconfigdialog.cpp, both top level items ("Application" and "Editor Component") are disabled:

KPageWidgetItem *applicationItem = addPage(new QWidget, i18n("Application"));
applicationItem->setIcon(QIcon::fromTheme(QStringLiteral("preferences-other")));
applicationItem->setHeader(i18n("Application Options"));
applicationItem->setCheckable(false);
applicationItem->setEnabled(false);
m_applicationPage = applicationItem;`


and

// editor widgets from kwrite/kwdialog
m_editorPage = addPage(new QWidget, i18n("Editor Component"));
m_editorPage->setIcon(QIcon::fromTheme(QStringLiteral("accessories-text-editor")));
m_editorPage->setHeader(i18n("Editor Component Options"));
m_editorPage->setCheckable(false);
m_editorPage->setEnabled(false);

By enabling them, they're presented with the same color group as their children, but now their clickable, with no content currently available (see attached screenshot for example).

What do you think: should a default content be added to this top level entries or should we work in distinguishing enabled and clickable behavior (maybe there is already something similar in the frameworks)?
Comment 4 Christoph Cullmann 2020-07-21 19:12:38 UTC
I agree that non-disabled is better readable, but I would like to avoid this empty top level pages.

Not sure if there is already something that allows that in the API.
Comment 5 Christoph Cullmann 2020-09-27 16:47:44 UTC
We are working on redoing the config dialog:

https://invent.kde.org/utilities/kate/-/merge_requests/105
Comment 6 Nate Graham 2020-09-28 15:26:31 UTC
This was fixed by https://invent.kde.org/utilities/kate/-/commit/895160f40b9f55c50a17f7a9d968b952bcac4f50 in Kate 20.12