Bug 424349 - Timer no longer runs command
Summary: Timer no longer runs command
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: timer (show other bugs)
Version: 5.19.3
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
: 426555 426864 429518 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-17 19:26 UTC by JayKim
Modified: 2020-12-07 11:43 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Revert runCommand change (402 bytes, patch)
2020-07-17 19:26 UTC, JayKim
Details

Note You need to log in before you can comment on or make changes to this bug.
Description JayKim 2020-07-17 19:26:42 UTC
Created attachment 130207 [details]
Revert runCommand change

SUMMARY
When a command is set and runCommand is enabled, nothing is executed. It doesn't appear from strace that anything is even attempted to be run.

This appears to have been introduced in commit 47381a65debe01a0a015e1aa423cbb78af649648 (in applets/timer/plugin/timer.cpp).  I can confirm reverting that change still builds and fixes the issue for me, trivial patch attached.

Not sure if this change was a mistake, why it breaks things, or if reverting it will have other side effects.

STEPS TO REPRODUCE
1. Run the timer applet
2. Configure Timer -> Advanced -> "After timer completes" -> enable and set command
3. Start countdown

OBSERVED RESULT
No observable command run, nothing in logs, strace shows no fork


EXPECTED RESULT
Command is run


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kernel 5.7.8-gentoo
(available in About System)
KDE Plasma Version: 5.19.3
KDE Frameworks Version: 5.72.0
Qt Version: 5.15.0

ADDITIONAL INFORMATION
Comment 1 Alexander Lohnau 2020-07-21 09:23:30 UTC

*** This bug has been marked as a duplicate of bug 332490 ***
Comment 2 JayKim 2020-07-21 15:16:25 UTC
Sorry to reopen, but I don't think this is a duplicate. It appears to be the same issue, but this bug is for the timer plasma applet, not the ktimer app.
Comment 3 Alexander Lohnau 2020-07-21 15:38:32 UTC
No reason to be sorry, I am sorry for assuming that they use the same backend.

I will write a patch!
Comment 4 Bug Janitor Service 2020-07-21 15:58:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/13
Comment 5 Alexander Lohnau 2020-07-23 18:34:18 UTC
Git commit 4854cd0e0e06d727ab3175e07acb792429c4e834 by Alexander Lohnau.
Committed on 23/07/2020 at 17:43.
Pushed by alex into branch 'master'.

Fix timer applet commands with arguments

M  +1    -0    applets/timer/CMakeLists.txt
M  +7    -2    applets/timer/plugin/timer.cpp

https://invent.kde.org/plasma/kdeplasma-addons/commit/4854cd0e0e06d727ab3175e07acb792429c4e834
Comment 6 Alexander Lohnau 2020-09-16 06:03:02 UTC
*** Bug 426555 has been marked as a duplicate of this bug. ***
Comment 7 corebell.it 2020-12-07 11:43:04 UTC
*** Bug 426864 has been marked as a duplicate of this bug. ***
Comment 8 corebell.it 2020-12-07 11:43:19 UTC
*** Bug 429518 has been marked as a duplicate of this bug. ***