Bug 423965 - Wishlist: Update fingerprints as sub option in Maintenance menu
Summary: Wishlist: Update fingerprints as sub option in Maintenance menu
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Maintenance-Similarities (show other bugs)
Version: 7.0.0
Platform: Other All
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-07 11:46 UTC by fellowbiological
Modified: 2020-07-07 20:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0
Sentry Crash Report:


Attachments
Clarification image (42.05 KB, image/png)
2020-07-07 11:46 UTC, fellowbiological
Details

Note You need to log in before you can comment on or make changes to this bug.
Description fellowbiological 2020-07-07 11:46:58 UTC
Created attachment 129956 [details]
Clarification image

SUMMARY
The sub option to Update fingerprints in the Rebuild Finger-prints category in the Maintenance menu would be nice to have.

Currently when I update my collection I have use the Maintenance menu to Rebuild Finger-prints, but rebuilding it from scratch is too slow and unnecessary so I check the "Scan for changed or non-cataloged items (faster)" sub option. This only seems to clean up existing entries in the similarities database, so I have to afterwards go to the Similarity->Duplicates window and click the Update fingerprints button at the bottom, in order to add new items to the similarities database.

If this was added it would speed up my workflow a bit, since I'd only have to use the Maintenance menu. Thanks.

ADDITIONAL INFORMATION
See attached image for clarification of what I mean.
Comment 1 Maik Qualmann 2020-07-07 16:25:51 UTC
The "Update Fingerprints" option is the same as in the maintenance tool with the activated option "Scan for changed or non-cataloged items (faster)". There is no difference between the two if all albums are selected in the maintenance tool. It is not necessary to run "Update Fingerprints" again in the similarity window.

Maik
Comment 2 fellowbiological 2020-07-07 17:30:28 UTC
(In reply to Maik Qualmann from comment #1)
> The "Update Fingerprints" option is the same as in the maintenance tool with
> the activated option "Scan for changed or non-cataloged items (faster)".
> There is no difference between the two if all albums are selected in the
> maintenance tool. It is not necessary to run "Update Fingerprints" again in
> the similarity window.
> 
> Maik

Thanks for clarifying that because I think I might've discovered a bug with the "Scan for changed or non-cataloged items (faster)" option in the maintenance tool then, in which it doesn't properly get updated with newly added items found by the "Scan for new items" option and therefore doesn't add them to the similarities database.

This seems to be why I had to use the "Update Fingerprints" button afterwards or else the newly added images wouldn't show up when doing fuzzy image searches. I tried running the maintenance tool twice in a row instead and yes, it has the same effect as running the maintenance tool and then the "Update Fingerprints" option.

Should I edit this to be a bug report or add a new bug report?
Comment 3 Maik Qualmann 2020-07-07 18:42:45 UTC
The "Scan for new items" does not automatically add the fingerprint data to the similarities database, that is normal and is intended for speed reasons. The fingerprint maintenance run after adding new items is always necessary. I tested here again, after adding 2 similar new images and after the fingerprint maintenance run, they are recognized.

Maik
Comment 4 fellowbiological 2020-07-07 19:16:22 UTC
What I meant is combining "Scan for new items" and "Scan for changed or non-cataloged items (faster)" in the same maintenance run. If I do that it'll first do the new item scan and afterwards do the fingerprints generation and I expect it to be aware of the newly added items from the scan, but it doesn't in my case, it'll just check existing items to see if they're missing etc. Is that how it's intended? If I do them both in separate maintenance runs it works fine, but it's a bit more inconvenient to use.

I'm using Windows 7 if it's somehow related to the operating system.
Comment 5 Maik Qualmann 2020-07-07 20:44:43 UTC
Ok I understand. If the scan finds new albums, the search for fingerprints is based on the albums list before. I fix it.

Maik
Comment 6 Maik Qualmann 2020-07-07 20:48:58 UTC
Git commit 4067d7a2d2f1f149b6ccfac1bedef5d82c9116fd by Maik Qualmann.
Committed on 07/07/2020 at 20:45.
Pushed by mqualmann into branch 'master'.

update album und tags list after scan for new items
FXED-IN: 7.0.0

M  +2    -1    NEWS
M  +14   -0    core/utilities/maintenance/maintenancemngr.cpp

https://invent.kde.org/graphics/digikam/commit/4067d7a2d2f1f149b6ccfac1bedef5d82c9116fd