Bug 423932 - kdeconnect-sms: Clicking on "About" in the hamburger menu multiple times spawns multiple about frames
Summary: kdeconnect-sms: Clicking on "About" in the hamburger menu multiple times spaw...
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: common (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
: 438595 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-06 15:50 UTC by Nikhil Prabhu
Modified: 2021-06-18 05:28 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/network/kdeconnect-kde/commit/c0cbcc0d36c58f20d0ae063c757a53ec75d6076f
Version Fixed In:
Sentry Crash Report:

Attachments
Screenshot (129.07 KB, image/png)
2020-07-06 15:50 UTC, Nikhil Prabhu 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nikhil Prabhu 2020-07-06 15:50:57 UTC 
Created attachment 129941 [details]
Screenshot

SUMMARY

I'm currently using KDE Connect on openSUSE Tumbleweed with KDE Plasma 5.19.2. I've noticed that when clicking on the "About" menu action in the hamburger menu in KDE Connect SMS multiple times, it spawns multiple "About" frames within the window with no proper way of closing them.

STEPS TO REPRODUCE
1. Open KDE Connect SMS.
2. Click the hamburger menu and click "About".
3. Repeat step 2 multiple times.

OBSERVED RESULT

Multiple "About" frames open.

EXPECTED RESULT

Only a single "About" frame should spawn, and should have a proper method of closing it.

SOFTWARE/OS VERSIONS

Linux: openSUSE Tumbleweed (20200701)
KDE Plasma Version: 5.19.2
KDE Frameworks Version: 5.71.0
Qt Version: 5.15.0

ADDITIONAL INFORMATION
Comment 1 Nicolas Fella 2020-07-07 13:40:07 UTC 
We're currently in the process of formalizing and unifying the behaviour of various About Pages and this will be addressed in the process.

See https://phabricator.kde.org/T13260 for more context
Comment 2 Bug Janitor Service 2021-06-07 16:23:45 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/398
Comment 3 Nicolas Fella 2021-06-16 11:08:55 UTC 
Git commit c0cbcc0d36c58f20d0ae063c757a53ec75d6076f by Nicolas Fella, on behalf of Felipe Kinoshita.
Committed on 16/06/2021 at 11:08.
Pushed by nicolasfella into branch 'master'.

Push a new layer when entering About Page in the SMS App

This commit replaces `pageStack.push...` to `pageStack.layers.push...`
when entering the About Page in the SMS App.

M  +4    -2    smsapp/qml/main.qml

https://invent.kde.org/network/kdeconnect-kde/commit/c0cbcc0d36c58f20d0ae063c757a53ec75d6076f
Comment 4 Felipe Kinoshita 2021-06-18 05:28:03 UTC 
*** Bug 438595 has been marked as a duplicate of this bug. ***