SUMMARY Problem: "undo" does not always undo flood fill but will undo actions before and after it. System: Linux Mint 20 XFCE Version: Krita 4.3.0 STEPS TO REPRODUCE (not all these may be necessary, but pretty sure filling twice has to happen.) Starting with 7 layers. One has outlines. 1) duplicate the outline layer and hide the original 2) use the Contiguous Selection Tool to select 5 or six areas on the outline layer 3) fill with Foreground Color 4) deselect all 5) use the Contiguous Selection Tool to select 5 or six areas on the outline layer 6) change Foreground Color 7) fill with new Foreground Color 8) deselect all 7) start to undo all the previous actions. It takes a while because of all the selections. When you get to the most recent flood fill it will be undone. Then more selection undos and when you get to the original flood fill it will not undo, but you can go past it and undo the other selection things. OBSERVED RESULT: The original flood fill cannot be undone, and areas that were covered due to the Grow/Shrink Selection feature are not restored. EXPECTED RESULT: Restore the file to its condition before the flood fill happened. SOFTWARE/OS VERSIONS Version: Krita 4.3.0 System: Linux Mint 20 XFCE System: Kernel: 5.4.0-40-generic x86_64 bits: 64 compiler: gcc v: 9.3.0 Desktop: Xfce 4.14.2 tk: Gtk 3.24.13 wm: xfwm4 dm: LightDM Distro: Linux Mint 20 Ulyana base: Ubuntu 20.04 focal Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
I can confirm this for the 4.3.0 appimage and it goes all the way back to version 4.2.0. However, it seems to have been fixed in the latest builds and I suggest that you use the nightly stable build 4.3.1 alpha appimage from here: https://binary-factory.kde.org/job/Krita_Stable_Appimage_Build/ if the behaviour of 4.3.0 is of concern to you. However, my testing was done using a simplified situation so please do further tests with the 4.3.1 alpha and then hopefully come back and mark this as RESOLVED FIXED when you're convinced that it has been fixed. OBSERVATIONS ON 4.3.0. It only happens with selections made using the Contiguous Selection tool. For suitable images, use of the Similar Colour Selection tool does not give the problem while the Contiguous Selection tool does. A more simple way to see this is to have one layer with one selectable region which is selected then filled then deselected then selected again then filled again and then perform successive Undo actions. It may look more interesting and be easier to observe if you have more than one region but it's not neccessary to have that.