Bug 423736 - remove IgnoreMaximumSize=bool support
Summary: remove IgnoreMaximumSize=bool support
Status: REPORTED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: git master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KIO Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-01 11:32 UTC by Harald Sitter
Modified: 2020-07-01 11:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2020-07-01 11:32:43 UTC 
kdelibs introduced

> commit f7fb9947e822f0ae7dfb9c2c32f1ea367e10f4fd
> Author: Simon MacMullen <simon@macmullen.fsnet.co.uk>
> Date:   Sun Jun 16 10:54:09 2002 +0000
> 
>     Added check for IgnoreMaximumSize property, for the video creator (as it doesn't
>     make any difference in speed how big the video file is)
>     
>     svn path=/trunk/kdelibs/; revision=161343

While that is probably true for many preview types it makes no sense from a UI POV. There's a setting that allows the user to limit the maximum size for which previews are generated. The intricate delicacies of performance impacts of various file types are lost on users, all they'll see is previews generated for files that shouldn't have them.
e.g. bug #423544

Also, I'm not sure I trust third parties with making the call on whether or not they have to obey the rules.

To that end I propose we stop honoring IgnoreMaximumSize set in the desktop file of the thumbnailers. It wasn't documented as a feature anyway it seems.