Bug 423539 - Password field iconigraphy to show/hide password is inverted
Summary: Password field iconigraphy to show/hide password is inverted
Status: REPORTED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.105.0
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-26 11:33 UTC by Claudius Ellsel
Modified: 2024-09-08 20:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Claudius Ellsel 2020-06-26 11:33:06 UTC
SUMMARY
On the login screen and the lock screen the password box where the password is entered has the icon appearance for showing and hiding the password inverted.

STEPS TO REPRODUCE
1. Use the login screen or lock the session
2. Type in characters in the password box
3. An eye icon appears on the right of the password box

OBSERVED RESULT
The eye icon is striked through when the password is hidden and normal when the password is shown

EXPECTED RESULT
The eye icon should be normal when the password is hidden and striked through when the password is shown. This would indicate what will happen when the icon is clicked.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
This is how it works on Windows and how I expect it to work. Also this might be a regression. I think I identified those two relevant lines in two files: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/lookandfeel/contents/lockscreen/MainBlock.qml#L32 and https://invent.kde.org/plasma/plasma-workspace/-/blob/master/sddm-theme/Login.qml#L11

However, I could not dig deeper. This might be a bug in a more central component.
Comment 1 Claudius Ellsel 2020-06-26 11:34:21 UTC
Forgot to provide system information:

Operating System: Manjaro Linux
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.70.0
Qt Version: 5.15.0
Kernel Version: 5.4.43-1-MANJARO
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-4670K CPU @ 3.40GHz
Memory: 7,7 GiB
Comment 2 2wxsy58236r3 2020-10-19 03:50:27 UTC
> Eye icon is striked through when the password is hidden
> and normal when the password is shown
Example: KeePassXC

> Eye icon is normal when the password is hidden
> and striked through when the password is shown
Example: ProtonMail
Comment 3 ratijas 2023-04-10 08:54:33 UTC
So, it's a classic case between "visuals of this button describe what this button is doing when clicked" vs. "visuals of this button represent current state"
Comment 4 Nate Graham 2023-04-10 13:39:24 UTC
Yeah, we get these complaints a lot for icons-only toggle buttons. Adding visible text usually clarifies the situation, but adding text doesn't really make sense in this context.
Comment 5 2wxsy58236r3 2023-04-20 11:31:05 UTC
Can we borrow the idea from https://ux.stackexchange.com/a/60980 ?

> A reasonable compromise would be to have the button not highlighted (have a neutral background color perhaps) when it is on the off state, and highlight it (change background color) when it is in the on state.