Bug 423521 - Flickering on preview when changing the parameters of the filter in Filted Dialog
Summary: Flickering on preview when changing the parameters of the filter in Filted Di...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: unspecified All
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-25 22:15 UTC by stephen
Modified: 2021-01-15 08:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
glitchy_rendering (2.72 MB, image/gif)
2020-06-25 22:27 UTC, stephen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description stephen 2020-06-25 22:15:22 UTC
SUMMARY
This feedback is a request to have future versions of Krita to render the canvas in real-time without glitches for all possible operations like the one you see in the video attached.

ADDITIONAL INFORMATION :
I use Krita 4.3.1 alpha stable build on Windows 10 1909 currently.
Comment 1 stephen 2020-06-25 22:27:03 UTC
Created attachment 129686 [details]
glitchy_rendering
Comment 2 vanyossi 2020-07-08 23:54:47 UTC
Real-time? you are asking too much for current technology. Performance is one of our top priorities so we do have some plans already laid out on how to improve speed on filter rendering to allow a faster rendering. As it is the canvas is rendered in a tiled way to avoid any delay, as if you change the filter settings mid renering it can cancel the tiles not yet processed. Without tiles you would need to wait for your entire image to be processed with the filter for the operation to be shown, which in turn would be very slow.

As long as the different tiles are not baked in the final applied result I would mark this as an invalid bug. You can reopen only if the filter is applying the glitches onto your image.
Comment 3 stephen 2020-07-09 12:53:01 UTC
(In reply to vanyossi from comment #2)
> Real-time? you are asking too much for current technology. Performance is
> one of our top priorities so we do have some plans already laid out on how
> to improve speed on filter rendering to allow a faster rendering. As it is
> the canvas is rendered in a tiled way to avoid any delay, as if you change
> the filter settings mid renering it can cancel the tiles not yet processed.
> Without tiles you would need to wait for your entire image to be processed
> with the filter for the operation to be shown, which in turn would be very
> slow.
> 
> As long as the different tiles are not baked in the final applied result I
> would mark this as an invalid bug. You can reopen only if the filter is
> applying the glitches onto your image.

Greetings again. OK. Actually, that's what I want : bake the final result of the tiled parts before displaying/previewing the changes on the canvas. I understand that you have plenty of optimizations in the TODO list of your roadmap. But at least, do you get the idea ? If needed, I'll make another gif/video to show the behavior I'm looking for. Just let me know.
Comment 4 Dmitry Kazakov 2020-07-13 09:43:12 UTC
I think the problem is in the tiled flickering when updating the filter configuration. We have special code to avoid that in KisFilterManager, but for some reason it doesn't solve the issue for long filters (perhaps, because of need-rects, which gets updated accidentally as well?). So that is actually a bug :)
Comment 5 Dmitry Kazakov 2020-07-13 09:43:31 UTC
Upgrade to a minor bug
Comment 6 Dmitry Kazakov 2021-01-15 08:53:53 UTC
The bug should now be fixed in 
https://invent.kde.org/graphics/krita/-/commit/029deeef867866d744889a6150da2a372c4c3e6f