Bug 423487 - FileFetchJob blocks gui thread
Summary: FileFetchJob blocks gui thread
Status: REPORTED
Alias: None
Product: baloo-widgets
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Stefan Brüns
URL:
Keywords:
Depends on:
Blocks: 423082
  Show dependency tree / graph
 
Reported: 2020-06-25 11:09 UTC by Harald Sitter
Modified: 2020-06-26 10:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2020-06-25 11:09:33 UTC 
When disk IO is slow FileFetchJob can block dolphin's GUI entirely because it does a blocking waitForFinished call. At a glance that's unnecessary given the job has an async api and could use qprocess by attaching to signals.

#7  QProcessPrivate::waitForFinished (this=this@entry=0x557a8c2c3420, msecs=msecs@entry=30000) at io/qprocess_unix.cpp:839
#8  0x00007faf075a1751 in QProcess::waitForFinished (this=<optimized out>, msecs=30000) at io/qprocess.cpp:1929
#9  0x00007faf09201b2d in Baloo::FileFetchJob::doStart (this=0x557a8c8c5bd0) at ./src/filefetchjob.cpp:81
#10 0x00007faf0765d2a9 in QObject::event (this=0x557a8c8c5bd0, e=0x557a8c908d00) at kernel/qobject.cpp:1339