Bug 423434 - UserAction icon is lost
Summary: UserAction icon is lost
Status: RESOLVED FIXED
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: 2.7.2
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Davide Gianforte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-24 10:49 UTC by Dmitry Yasenovsky
Modified: 2020-08-10 08:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Yasenovsky 2020-06-24 10:49:42 UTC
SUMMARY
UserAction icon is lost.

STEPS TO REPRODUCE
1. Open Krusader.
2. Menu "Useractions" -> "Manage User Actions..."
3. Create new item "Test 1" with any icon.
4. Save item and close dialog window.
5. Open "Manage Your Useractions" dialog again: Menu "Useractions" -> "Manage User Actions..."
6. Select item "Test 1".
7. Change "Title:" or "Command:" and press button "Apply".

OBSERVED RESULT
Now icon for this item was lost (Icon button is empty in dialog).

EXPECTED RESULT
Existing icon should not be lost.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian GNU/Linux 10 (buster)
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.3

ADDITIONAL INFORMATION
Additionally I tested Krusader 2.8.0-dev "Bleeding Edge" (2020-06-23).
The bug exists in this version too.
Comment 1 Bug Janitor Service 2020-06-30 18:57:35 UTC
A possibly relevant merge request was started @ https://invent.kde.org/utilities/krusader/-/merge_requests/19
Comment 2 Davide Gianforte 2020-08-10 08:55:02 UTC
Git commit 259fb603014d4abe9629342ff8748c6328334516 by Davide Gianforte.
Committed on 10/08/2020 at 08:54.
Pushed by gengisdave into branch 'master'.

Fix UserAction icons

The button holding the useraction icon is not set when selecting an element,
but only when the icon is changed by the user. The last saved icon is applied
to the following change if its icon is not changed.
Related: bug 328936
FIXED: [ 328936 ] "User action manager"; lost icon
FIXED: [ 423434 ] UserAction icon is lost

M  +1    -1    krusader/ActionMan/actionproperty.cpp

https://invent.kde.org/utilities/krusader/commit/259fb603014d4abe9629342ff8748c6328334516