https://i.imgur.com/x4CNgFk.png Fit page icon (Change the magnification of the document view to a value that makes at least one whole page visible) to me is misleading. It looks like it suggest expanding while a click on it contracts page so that it fits program hight. I think the arrows should point inside to indicate contracting: https://i.imgur.com/L7WeNmd.png Or, even better, you can remove left and right arrows so that it shows that page will fit hight of program. https://i.imgur.com/58g4Mhv.png This would match look of the other icon that expands page to program width: https://i.imgur.com/3OtL7Zb.png Certainly the other use-case is possible when page is so minimized that a few pages are visible and clicking on this icon expands page but this is more rare situation. But even considering this, just leaving bottom and upper arrows makes much more sense to me: https://i.imgur.com/mquvqU8.png This indicates that page will fit vertically. And this is what this function actually does.
I forgot that some pdf documents can have more letter type size and landscape orientation of pages. But the point here is that at present Okular has the same icon for three different functions: https://i.imgur.com/g3sLsxa.png
The actions with same icon are: * Auto Fit * Fit Page * Zoom * Zoom (yes, two of them) I think one Zoom could be a magnifier. But at least these icons are not used in the same context. (Auto Fit and Fit Page are in zoom but don’t show their icons, Zoom is in tools, other Zoom doesn’t show its icon.) So there is no urgent need to give them distinct icons. I don’t agree that Fit Page is actually Fit Height. If you have a monitor that can be turned easily, Fit Page switches between Fit Width and Fit Height. And if you switch to Facing Pages or Overview mode, Fit Page will also switch to Fit Width. Whether the arrows should be inwards or outwards is a good question. Your arguments make sense to me. I don’t really have an opinion there, the arrows are barely visible in many cases. But that would be a Breeze Icons issue, not an Okular issue.
Yes. I reflected to late that there are different use-cases and other factors. In my opinion, the bottom line is that each function should have its own distinct icon, so that when I have them all on the panel they don't confuse me.
Well, If you put all these actions into your toolbar, you can configure both icon and text. What icons would you suggest for the other actions? I think we could use zoom-fit-height for Fit Page, if we can agree that it is semantically acceptable. If we implement horizontal page layout at some time (Bug 343910), it wouldn’t be acceptable.
This is pretty much an issue with Breeze icons and not Okular, right?
Just renaming text is not enough. I don't know whether it is Okular or Breeze issue. At this stage new design is welcomed. As I am not good at design I started topic on kde forum. Maybe someone will come up with a proposal: help design icons for Okular https://forum.kde.org/viewtopic.php?f=285&t=166740
@Nate Graham Feel free to change Product to Breeze. In linked thread on kde forum there are icons proposed. Maybe Breeze team will come up with something new.
These are the design guidelines for Breeze icons. I fear that the icons presented in the forum thread don’t work in 16px or 22px. https://hig.kde.org/style/icons/monochrome/index.html