Bug 423391 - Logout function no longer works
Summary: Logout function no longer works
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Lock/logout (show other bugs)
Version: 5.19.1
Platform: openSUSE Linux
: NOR major
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-23 10:32 UTC by BingMyBong
Modified: 2020-06-23 23:01 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description BingMyBong 2020-06-23 10:32:39 UTC
SUMMARY
Clicking on Logout widget doesn't do anything now but logout from the menu works.  Lock widget still works as it should.

STEPS TO REPRODUCE
1. Click Logout widget

OBSERVED RESULT
No change

EXPECTED RESULT
Logout and run my logout script

SOFTWARE/OS VERSIONS
tumbleweed:20200621
Qt: 5.15.0 KDE Frameworks: 5.71.0 - KDE Plasma:  5.19.1 - kwin 5.19.1
kmail2 5.14.2 (20.04.2) - akonadiserver 5.14.2 (20.04.2) - Kernel:  5.7.2-1-default  - xf86-video-nouveau:  1.0.16
Comment 1 Paul 2020-06-23 13:21:43 UTC
Probably beneficial to clarify which "Logout widget" you're referring to.

Able to partly confirm, (same Software/OS Versions as yourself).

"Leave" from the right click Desktop Context Menu now does nothing.

Menu -> Power / Session -> Logout works as expected.
Comment 2 Paul 2020-06-23 13:23:05 UTC
Should add, this is not the same as Bug 422870
Comment 3 BingMyBong 2020-06-23 14:26:53 UTC
(In reply to Paul from comment #1)
> Probably beneficial to clarify which "Logout widget" you're referring to.

Its just called Lock/Logout - no real name. its installed from "+Add Widgets.."

> Able to partly confirm, (same Software/OS Versions as yourself).
> 
> "Leave" from the right click Desktop Context Menu now does nothing.
> 
> Menu -> Power / Session -> Logout works as expected.
Comment 4 David Edmundson 2020-06-23 14:59:38 UTC
Found it :/

As a temporary workaround you can enable "confirm shutdown options" and it'll work again
Comment 5 Bug Janitor Service 2020-06-23 15:19:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/113
Comment 6 Paul 2020-06-23 15:30:17 UTC
(In reply to David Edmundson from comment #4)
> Found it :/
> 
> As a temporary workaround you can enable "confirm shutdown options" and
> it'll work again

Yes, enabling "Confirm logout" restores the correct behaviour (after a re-login)

Thanks :)
Comment 7 BingMyBong 2020-06-23 17:06:00 UTC
(In reply to David Edmundson from comment #4)
> Found it :/
> 
> As a temporary workaround you can enable "confirm shutdown options" and
> it'll work again

I had to log out via the menu before it would work again.  Next issue coming up.

On the next (and subsequent) logout, it pops up the confirmation menu with "Logout" highlighted as i expected (as i've configuring "logout" as the default), if you leave it a few seconds the focus jumps to the "Shutdown" and the countdown to shutting down continues - it can be cancelled but its a strange thing to do.  If you do cancel it and logout again, it goes straight to Shutdown as the default so you can't logout and leave it.
Comment 8 Paul 2020-06-23 20:21:43 UTC
@BingMyBong

Can't replicate that one...

Left for the full 30sec countdown, system logs out.

Log back in and repeated, several times, tried with and without cancelling the countdown.

Settings for ksmserverrc:

[General]
excludeApps=
loginMode=emptySession
screenCount=1
Comment 9 BingMyBong 2020-06-23 20:35:22 UTC
(In reply to Paul from comment #8)
> @BingMyBong
> 
> Can't replicate that one...
> 
> Left for the full 30sec countdown, system logs out.
> 
> Log back in and repeated, several times, tried with and without cancelling
> the countdown.
> 
> Settings for ksmserverrc:
> 
> [General]
> excludeApps=
> loginMode=emptySession
> screenCount=1

This is my ksmserverrc:

[$Version]
update_info=ksmserver_update_loginMode_value.upd:ksmserver_update_loginMode_value_default_enum

[General]
excludeApps=
loginMode=emptySession
shutdownType=0
Comment 10 Paul 2020-06-23 20:54:49 UTC
What if you remove the line "shutdownType=0"

Although playing with the "Default leave option" setting that (shutdownType=0) is for "End Session", I guess without it that's what it defaults to anyway.
Comment 11 David Edmundson 2020-06-23 22:36:32 UTC
stupid gitlab

david wrote:
> @bug_id = 423391
> @bug_status = RESOLVED
> @resolution = FIXED
> @cf_commitlink = https://invent.kde.org/plasma/plasma-workspace/commit/fcf4aabe4209fa5a797953e36546394739f6fa75
>
> Git commit fcf4aabe4209fa5a797953e36546394739f6fa75 by David Edmundson.
> Committed on 23/06/2020 at 15:20.
> Pushed by davidedmundson into branch 'Plasma/5.19'.
>
> Fix DBus service used in shutdown interface
>
> During Plasma 5.18, ksmserver was cleverly split so it hosted the new
> new interface registering both services names org.kde.ksmserver and
> org.kde.Shutdown.
>
> This way we could do a gradual port, update the libs, and migrate the
> final code without any breakages. It was a good plan in theory.
>
> In 5.19 we did the final actual splitting, unfortunately in
> libkworkspace on the path where we skip logout confirmation had the
> wrong name.
>
> M  +1    -1    libkworkspace/sessionmanagement.cpp
>
> https://invent.kde.org/plasma/plasma-workspace/commit/fcf4aabe4209fa5a797953e36546394739f6fa75