Bug 423311 - Skrooge doesn't show key error message, only summary error
Summary: Skrooge doesn't show key error message, only summary error
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: Trunk from git
Platform: Flatpak Linux
: NOR normal
Target Milestone: 25.1.0
Assignee: Guillaume DE BURE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-21 09:13 UTC by skierpage
Modified: 2020-07-06 10:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2020-06-21 09:13:10 UTC
SUMMARY
I tried to import a CSV, it failed with a red bar at the top:
  [ERR-5]: Import of file named '/path/to/file.csv' failed
and the same message in the Messages panel. This doesn't identify the problem.
I went to all the trouble of setting `export SKGTRACE=10` and reviewing the trace output and then realized I could click the [History] button at the top before it goes away to see the missing actual error as well as the failure summary:
  [ERR-5]: Columns date and amount not found. Set import parameters in settings (Configure Skrooge... / Import/Export / CSV / Edit regular expressions...).
and then this secondary message does appear in the Messages panel.

I don't fully understand what's happening but it seems both messages should appear in the transient top panel and in the Messages panel without having to click on a [History] button that goes away after a few seconds.

STEPS TO REPRODUCE
1. Find a bad CSV file
2. File > Import > Import...

OBSERVED RESULT
You only see Skrooge's final report of import failure, not the message about the actual problem that caused the problem.

EXPECTED RESULT
Show all Skrooge's messages about the import, not just the last one. I guess if there were dozens of messages the transient top bar might overflow, but it seems there's enough room to display two messages, and an indicator '^...[more]...^' if there are more. Maybe this [more] could be a button replacing [History].
I don't see why the Messages panel doesn't show all messages, without having to click the transient [History] button.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: n/a
KDE Frameworks Version: 5.69.0
Qt Version: Qt 5.14.2 (built against 5.14.2) , on xcb

ADDITIONAL INFORMATION
Comment 1 Stephane MANKOWSKI 2020-07-06 10:05:57 UTC
Git commit a1b3c05b66d962b03dd3b844e0e55e506080c90f by Stephane MANKOWSKI.
Committed on 06/07/2020 at 10:05.
Pushed by smankowski into branch 'master'.

Skrooge doesn't show key error message, only summary error

M  +1    -0    CHANGELOG
M  +4    -3    skgbasegui/skgmainpanel.cpp

https://invent.kde.org/office/skrooge/commit/a1b3c05b66d962b03dd3b844e0e55e506080c90f