Bug 423260 - Changing graph title and pressing cancel in the dialog changes the name anyway
Summary: Changing graph title and pressing cancel in the dialog changes the name anyway
Status: RESOLVED FIXED
Alias: None
Product: ksysguard
Classification: Applications
Component: ksysguard (show other bugs)
Version: 5.19.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-20 09:17 UTC by Matej Mrenica
Modified: 2020-07-01 13:07 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/ksysguard/commit/3cd5873692cf58e7d046a402d125476538596811
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2020-06-20 09:17:02 UTC 
SOFTWARE/OS VERSIONS
KDE Frameworks Version: 5.71
Qt Version: 5.15.0
Comment 1 groot 2020-06-28 20:51:50 UTC 
This bug report needs more details:
- does this apply to ksysguard the application, or to widgets?
- what sequence of actions do you take to get to "changing graph title"?

That said, I end up with being *un*able to change the title of a widget after changing it once, but that's a different bug report entirely.
Comment 2 Matej Mrenica 2020-06-29 06:04:29 UTC 
This is ksysguard application. Step by step:
1. create a new tab
2. add a graph from the right
3. right-click on the y axis
4. select "Properties"
5. Dialog opens, on the first tab there is "Title" field
6. change the title to something else
7. Press "Cancel"
8. The graph title shown in Bold has changed
Comment 4 Matej Mrenica 2020-06-30 08:51:15 UTC 
I can confirm the MR fixes this.
Comment 5 Arjen Hiemstra 2020-07-01 13:07:39 UTC 
Git commit 3cd5873692cf58e7d046a402d125476538596811 by Arjen Hiemstra, on behalf of Adriaan de Groot.
Committed on 01/07/2020 at 13:07.
Pushed by ahiemstra into branch 'master'.

Only apply the (changed) settings if the dialog is
finished via the OK button (or some other way of accepting
the dialog). Clicking *cancel* should not apply the
changed settings.

M  +6    -1    gui/SensorDisplayLib/FancyPlotter.cpp

https://invent.kde.org/plasma/ksysguard/commit/3cd5873692cf58e7d046a402d125476538596811