Bug 423254 - Android: color picker when using "Color to Alpha" filter doesn't work
Summary: Android: color picker when using "Color to Alpha" filter doesn't work
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color Selectors (show other bugs)
Version: 4.3.0
Platform: Android Android 10.x
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-20 05:56 UTC by AppTest
Modified: 2020-10-29 09:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description AppTest 2020-06-20 05:56:38 UTC
SUMMARY
Can't use color picker for "Color to Alpha" purposes, forcing me to manually enter a color the slower way.

STEPS TO REPRODUCE
1. Select menu > filter > colors > color to alpha > color picker color > color picker tool.
2. Attempt to click on a color on the canvas.

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
Color should be picked.

SOFTWARE/OS VERSIONS
Android 10 on Samsung Galaxy Tab S6 

ADDITIONAL INFORMATION
Using Android build based on 4.3.0 stable
Comment 1 sh_zam 2020-06-20 08:46:31 UTC
Can confirm the bug. 

Looks like the events are bound to the boundaries of the Color Picker Widget. So, when stylus/mouse is hovered outside the boundaries. The events stop being delivered to the widget.
Comment 2 sh_zam 2020-10-26 12:02:55 UTC
Git commit a159291b216f43980732d31bace8848421a199cb by Sharaf Zaman.
Committed on 26/10/2020 at 12:01.
Pushed by szaman into branch 'krita/4.3'.

Android: Color picker not working properly

When a modal dialog is used, events outside of the widget bounds isn't
received by modal window. This should make picker usable for all
widgets not just Color to Alpha.

M  +4    -0    libs/widgets/KisDlgInternalColorSelector.h

https://invent.kde.org/graphics/krita/commit/a159291b216f43980732d31bace8848421a199cb
Comment 3 sh_zam 2020-10-28 09:56:26 UTC
Git commit da3f4d70502f180f51309b074db94648cd61cd75 by Sharaf Zaman.
Committed on 28/10/2020 at 09:51.
Pushed by szaman into branch 'krita/4.4.0'.

Android: Color picker not working properly

When a modal dialog is used, events outside of the widget bounds isn't
received by modal window. This should make picker usable for all
widgets not just Color to Alpha.

(cherry picked from commit a159291b216f43980732d31bace8848421a199cb)

M  +4    -0    libs/widgets/KisDlgInternalColorSelector.h

https://invent.kde.org/graphics/krita/commit/da3f4d70502f180f51309b074db94648cd61cd75
Comment 4 sh_zam 2020-10-29 09:52:21 UTC
Git commit 7f68adda6b8fc8d50c1e40f2dcc76ec24002c707 by Sharaf Zaman.
Committed on 29/10/2020 at 09:51.
Pushed by szaman into branch 'master'.

Android: Color picker not working properly

When a modal dialog is used, events outside of the widget bounds isn't
received by modal window. This should make picker usable for all
widgets not just Color to Alpha.

(cherry picked from commit a159291b216f43980732d31bace8848421a199cb)

M  +4    -0    libs/widgets/KisDlgInternalColorSelector.h

https://invent.kde.org/graphics/krita/commit/7f68adda6b8fc8d50c1e40f2dcc76ec24002c707