SUMMARY After installing certain updates, e.g. a new kernel version, Discover's Notifier icon turns into a notification that the system needs to be restarted as critical updates were delivered. STEPS TO REPRODUCE 1. install an update to a package that requires a restart (e.g. kernel) 2. the notifier turns into a "system requires restart" 3. click on the notification icon OBSERVED RESULT Clicking on the icon opens Discover's "update" page. EXPECTED RESULT A dialogue about restarting the system should be shown instead. SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Neon KDE Plasma Version: 5.19.1 KDE Frameworks Version: 5.71 Qt Version: 5.14.2
Looks like we need to make the notification background also call DiscoverNotifier::reboot(), to match the behavior of clicking on the button.
Ah you were referring to the system tray item, not the desktop notification.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/12
Git commit dbef6113851cef53218e4ceccef44346605a3c70 by Nate Graham. Committed on 23/06/2020 at 13:33. Pushed by ngraham into branch 'master'. When the system needs a reboot, reboot when clicking notifier Otherwise it opens Discover's updates page which is blank, because the user has already performed all the updates. That's a bit silly. Let's instead make it reboot, and change the notifier's icon and text to reflect this. FIXED-IN: 5.20.0 M +8 -1 notifier/NotifierItem.cpp https://invent.kde.org/plasma/discover/commit/dbef6113851cef53218e4ceccef44346605a3c70
Nate, does your patch make the computer reboot if I click on the icon? If that's the case, I don't think it is a good way of addressing this. Say I don't want to reboot, but I accidentally click on the icon when trying to click on an adjacent one (e.g. I want to open Plasma Vaults and instead I click on the reboot icon). In that case, I could possibly face loss of data as I did not intend to reboot when clicking on the icon. A dialogue that says something like "your system has installed updates that require a reboot, would you like to do it now?" and a "reboot" button would be much better and would avoid unintended reboots and loss of data.
Yes, but you're asked to confirm first, just like you originally requested. :)
(In reply to Nate Graham from comment #6) > Yes, but you're asked to confirm first, just like you originally requested. > :) Okay, thanks for clarifying that! :)