Bug 423093 - Password is asked twice when connecting to a new WiFi network
Summary: Password is asked twice when connecting to a new WiFi network
Status: RESOLVED FIXED
Alias: None
Product: plasma-nm
Classification: Plasma
Component: applet (show other bugs)
Version: 5.19.1
Platform: Other Linux
: VHI normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords: regression
: 423168 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-06-17 09:36 UTC by popov895
Modified: 2020-08-19 10:56 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.20


Attachments
WiFi connection (443.99 KB, video/mp4)
2020-06-17 09:36 UTC, popov895
Details
journalctl (11.01 KB, text/x-log)
2020-06-17 11:55 UTC, popov895
Details

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2020-06-17 09:36:51 UTC
Created attachment 129441 [details]
WiFi connection

SUMMARY

Password is asked twice when connecting to a new WiFi network. At first the password is asked in the Network applet and then it's asked again through the system dialog.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE neon 5.19 User Edition
KDE Plasma Version: 5.19.1
KDE Frameworks Version: 5.71.0
Qt Version: 5.14.2
Comment 1 popov895 2020-06-17 09:42:58 UTC
Password length is 20 chars
Comment 2 popov895 2020-06-17 11:55:01 UTC
Created attachment 129443 [details]
journalctl
Comment 3 Jan Grulich 2020-06-17 12:56:10 UTC
It appears to be a bug caused by the applet rewrite to ExpandableListItem.

No idea how to fix it. @Nate, do you?

It appears that in changeState() when using "passwordDialogComponent.password" you don't get the password, because you are accessing a Component (a template), not any instance which actually represents the password field. You need direct access to the Loader to access the initialized password component, which is what we were using before.
Comment 4 Nate Graham 2020-06-17 14:23:04 UTC
Yeah, Kai reported this to me. I added support in Frameworks 5.72 to access the loader's item; see https://invent.kde.org/frameworks/plasma-framework/-/commit/7f9e189d87c040a952533713ff48d32872e0eadd

Shamefully I haven't actually produced a MR with the fix in plasma-nm though. I started working on it and got stuck and forgot about it, sorry.

If you have a quick fix feel free to commit it or send a MR! Since the fix requires a change in plasma-framework, the plasma-nm will have to land in 5.20, and then we can cajole packagers to backport both commits.
Comment 5 Bug Janitor Service 2020-06-17 19:56:52 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/4
Comment 6 Nate Graham 2020-06-17 19:57:35 UTC
Testing and assistance with the above WIP patch would be greatly appreciated.
Comment 7 Jan Grulich 2020-06-18 15:34:43 UTC
Git commit 271332cfc19ede398854113d037abfb35503179f by Jan Grulich, on behalf of Nate Graham.
Committed on 18/06/2020 at 15:34.
Pushed by grulich into branch 'master'.

[WIP] [applet] Fix inline password field component not working properly
FIXED-IN: 5.20

M  +2    -2    applet/contents/ui/ConnectionItem.qml

https://invent.kde.org/plasma/plasma-nm/commit/271332cfc19ede398854113d037abfb35503179f
Comment 8 Nate Graham 2020-06-19 17:47:55 UTC
*** Bug 423168 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2020-06-19 17:48:19 UTC
This fix landed in 5.20, but I have asked distro packagers to backport it for 5.19.
Comment 10 popov895 2020-08-19 10:56:34 UTC
Will this fix be backported to the KDE neon 5.19?