Bug 423031 - [Wayland] Modifier keys to move (shift), copy (ctrl) and create a link (ctrl+shift) don't work if pressed after I start to drag the file/folder
Summary: [Wayland] Modifier keys to move (shift), copy (ctrl) and create a link (ctrl+...
Status: RESOLVED UPSTREAM
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.90.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KIO Bugs
URL: https://codereview.qt-project.org/c/q...
Keywords: wayland
: 453786 457760 463277 479481 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-06-15 22:30 UTC by Patrick Silva
Modified: 2024-03-14 06:03 UTC (History)
25 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2020-06-15 22:30:40 UTC
STEPS TO REPRODUCE
1. start Wayland session
2. open Dolphin
3. enable split view by pressing F3 and open different locations in each pane
4. drag a file/folder from a pane to another one and do NOT release the mouse button when you stop cursor movement
4. press and hold shift (move here) or ctrl (copy here) or ctrl+shift (link here) modifier keys
5. release the mouse button

OBSERVED RESULT
if you pressed shift (move here)  or ctrl (copy here) in the step 4, context menu opens when you
release the mouse button. If you pressed ctrl+shift (link here) instead, Dolphin copies the dragged
file/folder to destination when you release the mouse button.

EXPECTED RESULT
all modifier keys should work as expected on Wayland

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.19.0
KDE Frameworks Version: 5.71.0
Qt Version: 5.15.0
Comment 1 Patrick Silva 2020-06-15 22:37:09 UTC
(In reply to Patrick Silva from comment #0)
> OBSERVED RESULT
> if you pressed shift (move here) or ctrl (copy here) in the step 4...

ops, I meant step 5 incorrectly numbered 4 lol
Comment 2 Thiago Sueto 2020-11-09 05:57:44 UTC
Can reproduce this consistently on Frameworks 5.75.
Comment 3 Méven Car 2020-11-21 09:45:17 UTC
Related upstream QT bug :
https://bugreports.qt.io/browse/QTBUG-79919
Comment 4 David Edmundson 2021-05-13 23:38:24 UTC
Needs dataDevicev3 which I have pending review upstream
Comment 5 Méven Car 2021-10-25 13:25:24 UTC
A (In reply to David Edmundson from comment #4)
> Needs dataDevicev3 which I have pending review upstream

I guess you are speaking of this one:
https://codereview.qt-project.org/c/qt/qtwayland/+/334777
Comment 6 Patrick Silva 2022-01-13 12:08:38 UTC
qt5-wayland package of KDE Qt available on Arch Linux has dataDevicev3 support but this bug persists.

Operating System: Arch Linux
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2
Graphics Platform: Wayland
Comment 7 Patrick Silva 2022-03-20 12:21:13 UTC
The modifier key only works if pressed before I start to drag the file/folder.


Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.93.0
Qt Version: 5.15.3
Graphics Platform: Wayland
Comment 8 kde.org 2022-05-14 14:40:43 UTC
(In reply to Patrick Silva from comment #7)
> The modifier key only works if pressed before I start to drag the
> file/folder.
> 
> 
> Operating System: KDE neon Unstable Edition
> KDE Plasma Version: 5.24.80
> KDE Frameworks Version: 5.93.0
> Qt Version: 5.15.3
> Graphics Platform: Wayland

That's the same behavior as on X11.
Comment 9 Patrick Silva 2022-05-14 15:11:48 UTC
(In reply to kde.org from comment #8)
> (In reply to Patrick Silva from comment #7)
> > The modifier key only works if pressed before I start to drag the
> > file/folder.
> > 
> > 
> > Operating System: KDE neon Unstable Edition
> > KDE Plasma Version: 5.24.80
> > KDE Frameworks Version: 5.93.0
> > Qt Version: 5.15.3
> > Graphics Platform: Wayland
> 
> That's the same behavior as on X11.

Not on my system.

Operating System: Arch Linux
KDE Plasma Version: 5.24.5
KDE Frameworks Version: 5.94.0
Qt Version: 5.15.3
Graphics Platform: Wayland
Comment 10 kde.org 2022-05-14 15:18:51 UTC
(In reply to Patrick Silva from comment #9)
> (In reply to kde.org from comment #8)
> > (In reply to Patrick Silva from comment #7)
> > > The modifier key only works if pressed before I start to drag the
> > > file/folder.
> > > 
> > > 
> > > Operating System: KDE neon Unstable Edition
> > > KDE Plasma Version: 5.24.80
> > > KDE Frameworks Version: 5.93.0
> > > Qt Version: 5.15.3
> > > Graphics Platform: Wayland
> > 
> > That's the same behavior as on X11.
> 
> Not on my system.
> 
> Operating System: Arch Linux
> KDE Plasma Version: 5.24.5
> KDE Frameworks Version: 5.94.0
> Qt Version: 5.15.3
> Graphics Platform: Wayland

Ok, it was the same behavior as on X11 for the last 7 years or so I've been using it. I switched to Wayland a couple of months ago, so I wasn't aware that it was recently fixed on X11, tracked here https://bugs.kde.org/show_bug.cgi?id=388259
Comment 11 Šimon (Simon) Rataj 2022-07-24 13:52:36 UTC
I can confirm presence of this bug in Plasma 5.25.3 (KDE neon 5.25, KDE Frameworks 5.96.0, Qt 5.15.5).
Comment 12 Nate Graham 2022-08-11 17:39:19 UTC
*** Bug 457760 has been marked as a duplicate of this bug. ***
Comment 13 Patrick Silva 2022-10-29 19:00:49 UTC
*** Bug 453786 has been marked as a duplicate of this bug. ***
Comment 14 Oded Arbel 2022-12-28 15:07:23 UTC
With current Neon unstable (Qt 5.15.7, Frameworks 5.101, Plasma 5.26.80) this is still an issue: when dragging a file from one split view of Dolphin to another, modifiers only take effect is held before the click to start dragging or if the modifier was released before releasing the drag.

Also, when dragging across Dolphin windows, even if the modifier was held before starting to drag - it will still not work. The only reliable way to get "force move" or "force copy" behavior is to press and release the modifier after starting to drag. This problem can also be seen with drag operations outside Dolphin.

Also, may be interesting to note that after releasing the modifier, the drag icon does not change unless I move the cursor again, so that my workflow is now looking like this:
1. Click and drag to destination, but don't release.
2. Click (hold and release) the desired modifier key.
3. Observe that confusingly the mouse drag cursor did not change, so consider your life choices (did I click the right modifier?) and maybe do it again to verify. Maybe wiggle the mouse around a bit to see that the icon changes to what I expect.
4. Release the drag.
(or just always use the popup menu)
Comment 15 Artur Rudenko 2023-05-11 14:03:35 UTC
It also appears to be a bug not only in dolphin; for example, in Kate, pressing "ctrl" to move cursor faster will only take effect when pressed before you press arrow keys. X11 works fine. Maybe it's a KWin issue?
Comment 16 Méven 2023-05-12 05:14:07 UTC
(In reply to Artur Rudenko from comment #15)
> It also appears to be a bug not only in dolphin; for example, in Kate,
> pressing "ctrl" to move cursor faster will only take effect when pressed
> before you press arrow keys. X11 works fine. Maybe it's a KWin issue?

Those are both qt issues, not communicating the modifiers change to the app or library.
Comment 17 Patrick Silva 2023-05-13 00:36:51 UTC
*** Bug 463277 has been marked as a duplicate of this bug. ***
Comment 18 Kai Uwe Broulik 2023-12-14 11:54:58 UTC
Potential fix https://codereview.qt-project.org/c/qt/qtwayland/+/525413
Comment 19 n0body_special 2024-01-06 19:57:59 UTC
(In reply to Kai Uwe Broulik from comment #18)
> Potential fix https://codereview.qt-project.org/c/qt/qtwayland/+/525413

That's cool, but how do we apply that fix? I really cannot understand anything from that page. I would appreciate some help, fixing this bug is very important to me
Comment 20 Patrick Silva 2024-01-07 15:26:13 UTC
*** Bug 479481 has been marked as a duplicate of this bug. ***